Hi Jonathan, No worries feel free to reject the PR, i understand its not in working state so no issues or use for comparison work etc.
I like the idea to maintain separate examples. I would be happy to help if you can guide me in right direction. Thanks and Regards, Nishant Raut https://twitter.com/rautnishant On Mon, Apr 27, 2020, 6:15 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > I'll run through some tests with it. There was a thread I kicked off about > using a Transformation process, and we'd effectively get two sets of > binaries (one javax, and one jakarta) from the same codebase. I don't have > a strong view on whether the actual source uses javax or jakarta, but we do > need to be able to support apps in both, and we'll need to support working > under javax for a fair amount of time. To merge in the PR, we'd want to at > least make sure that the build is green, and there are no regressions. I > suspects its actually the dependencies that will make this difficult. > > So, to set expectations, this might not get merged, or it might not get > merged right away. I definitely don't want you to take that negatively > though. This PR is *seriously* useful, as it throws up a number of > transformations that I don't think have been considered, so I'd definitely > like to run tests against it and compare its output to what is getting > transformed through the tools. > > For the examples PR, I'm wondering whether we can have a Jakarta examples, > and a Javax examples - what do you think? > > In terms of the Jakarta EE work, I feel very much inclined to use the > libraries from Geronimo, for the reasons Mark has suggested (licenses, > OSGi). Some progress we can there would be excellent. That code is in SVN > so you'd need to provide a patch on a JIRA ticket, or we can look to see if > we can get that moved over to Git to get a PR. > > Jon > > On Mon, Apr 27, 2020 at 12:49 PM Nishant Raut <nishant30...@gmail.com> > wrote: > > > Hi Jonathan, > > > > I have seen similar PR in jakarta flat rename, so once we have updated > > jakarta ee api it should work. > > > > Thanks and Regards, > > Nishant Raut > > https://twitter.com/rautnishant > > > > On Mon, Apr 27, 2020, 4:58 PM Jonathan Gallimore < > > jonathan.gallim...@gmail.com> wrote: > > > > > Thanks for sending these over - I'll take a look. Does it run / work? > > > > > > On Sun, Apr 26, 2020 at 6:47 PM Nishant Raut <nishant30...@gmail.com> > > > wrote: > > > > > > > Raised for examples as well. > > > > > > > > Thanks and Regards, > > > > Nishant Raut > > > > https://twitter.com/rautnishant > > > > > > > > On Sun, Apr 26, 2020, 8:28 PM Nishant Raut <nishant30...@gmail.com> > > > wrote: > > > > > > > > > Hi Jonathan and Team, > > > > > > > > > > I have raised PR for moving files from javax.* to jakarta.* > package. > > > Can > > > > > you please check and let me know if there are any changes required. > > > > > > > > > > Thanks and Regards, > > > > > Nishant Raut > > > > > https://twitter.com/rautnishant > > > > > > > > > > > > > > >
