It occurs to me that I maybe need to try this with your PR; so I'll do that now.
Jon On Thu, Jul 9, 2020 at 2:32 PM Jonathan Gallimore < [email protected]> wrote: > Hey JL > > I'm good for you to merge it. Quick question though - I'm running the > servlet TCK tests at the moment, and nothing is passing. Looks like the > issue is this: > </pre><p><b>Root Cause</b></p><pre>java.lang.ClassNotFoundException: > org.apache.tomee.security.provider.TomEESecurityAuthConfigProvider > java.net.URLClassLoader.findClass(URLClassLoader.java:382) > java.lang.ClassLoader.loadClass(ClassLoader.java:418) > java.lang.ClassLoader.loadClass(ClassLoader.java:351) > java.lang.Class.forName0(Native Method) > java.lang.Class.forName(Class.java:264) > > org.apache.catalina.authenticator.jaspic.AuthConfigFactoryImpl.createAuthConfigProvider(AuthConfigFactoryImpl.java:133) > > org.apache.catalina.authenticator.jaspic.AuthConfigFactoryImpl.doRegisterConfigProvider(AuthConfigFactoryImpl.java:111) > > org.apache.catalina.authenticator.jaspic.AuthConfigFactoryImpl.loadPersistentRegistrations(AuthConfigFactoryImpl.java:347) > > org.apache.catalina.authenticator.jaspic.AuthConfigFactoryImpl.<init>(AuthConfigFactoryImpl.java:68) > sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > Method) > > sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) > > sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > java.lang.reflect.Constructor.newInstance(Constructor.java:423) > > javax.security.auth.message.config.AuthConfigFactory$1.run(AuthConfigFactory.java:76) > > javax.security.auth.message.config.AuthConfigFactory$1.run(AuthConfigFactory.java:67) > java.security.AccessController.doPrivileged(Native Method) > > javax.security.auth.message.config.AuthConfigFactory.getFactory(AuthConfigFactory.java:66) > > org.apache.catalina.authenticator.AuthenticatorBase.findJaspicProvider(AuthenticatorBase.java:1382) > > org.apache.catalina.authenticator.AuthenticatorBase.getJaspicProvider(AuthenticatorBase.java:1375) > > org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:532) > > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) > > org.apache.tomee.catalina.OpenEJBSecurityListener$RequestCapturer.invoke(OpenEJBSecurityListener.java:97) > > org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:690) > > org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343) > > org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:373) > > org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65) > > org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868) > > org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1589) > > org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) > > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > > org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) > java.lang.Thread.run(Thread.java:748) > > I assume that this is overlapping on some of the work you've done. You got > any hints that might help me out? > > Cheers > > Jon > > On Thu, Jul 9, 2020 at 8:59 AM Jean-Louis Monteiro < > [email protected]> wrote: > >> Hi all, >> >> Time to step back and give you some updates. >> So far we are at >> 82 PASSED >> 4 FAILED >> >> Of the 4, 2 are under investigation on the Jakarta TCK side. >> 1 is related to the security manager and another one to JACC permissions. >> >> It may take some time to get the 4 fully completed, so I suggest we leave >> them until we hear back from Jakarta and we can fix them later. >> >> We are kinda in Pareto mode (20% of effort to cover 80% and the remaining >> may require too much effort for now). >> >> The PR is still up for review. There are a lot of todos in there and >> requires a lot more testing (unit and integration). TCK coverage is not >> enough. >> >> While we can dedicate more time to harden this part, any objection if we >> merge the PR? >> >> -- >> Jean-Louis Monteiro >> http://twitter.com/jlouismonteiro >> http://www.tomitribe.com >> >
