I think, that the write permissions are not assigned to my account yet - at least GitHub states "Only those with write access to this repository can merge pull requests." on all TomEE related repositories.
If I have them, I will do the merge myself :) Gruss Richard Am Donnerstag, den 14.01.2021, 10:56 +0100 schrieb Jean-Louis Monteiro: > Good updates > I approved it but did not merge. > > Can you go ahead and see if you can merge? > You should now be able to click the merge button, even on this repo. > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Thu, Jan 14, 2021 at 10:24 AM Zowalla, Richard < > richard.zowa...@hs-heilbronn.de> wrote: > > > Hi Cesar, > > > > thanks for the fast response and the hint! > > > > Finally, I was able to setup the TCK and execute some tests. > > > > I prepared a PR [1] to enhance the REAMDE. > > > > Gruss > > Richard > > > > [1] https://github.com/apache/tomee-tck/pull/15 > > > > Am Mittwoch, den 13.01.2021, 10:26 -0600 schrieb Cesar Hernandez: > > > Hi Richard, > > > > > > Therefore, I guess, that [2] is a pre-built version of the TCK. > > > > > > Yes, it's recommended to use a pre-build TCK version instead of > > > manually > > > build it. > > > > > > Any thoughts on this? > > > > If there are no objections, I would try to create a related PR > > > > with > > > > a > > > > README enhancement. > > > > > > Sure, go ahead. Thank you! > > > > > > El mié, 13 ene 2021 a las 10:15, Zowalla, Richard (< > > > richard.zowa...@hs-heilbronn.de>) escribió: > > > > > > > Just a short update: The build using [1] went fine. It produced > > > > a > > > > ZIP > > > > archive, which has an equal size to [2]. Therefore, I guess, > > > > that > > > > [2] > > > > is a pre-built version of the TCK. > > > > > > > > The new URL for downloading the TCK was introduced with TOMEE- > > > > 2849 > > > > with > > > > PR-12 [3]. Consequently, we might need to update the README > > > > accordingly. > > > > > > > > Any thoughts on this? > > > > > > > > If there are no objections, I would try to create a related PR > > > > with > > > > a > > > > README enhancement. > > > > > > > > Gruss > > > > Richard > > > > > > > > [1] > > > > https://github.com/eclipse-ee4j/jakartaee-tck/releases/tag/8.0.2 > > > > [2] > > > > > > > > > > https://download.eclipse.org/jakartaee/platform/8/jakarta-jakartaeetck-8.0.2.zip > > > > [3] https://github.com/apache/tomee-tck/pull/12 > > > > > > > > > > > > > > > > Am Mittwoch, den 13.01.2021, 14:43 +0000 schrieb Zowalla, > > > > Richard: > > > > > Hi all, > > > > > > > > > > today, I had some time and tried to setup the TomEE-TCK on my > > > > > machine > > > > > as I was curios on running the TCK locally. > > > > > > > > > > From previous mails, I identified the related repository on > > > > > GitHub > > > > > [1] > > > > > and cloned it. The documentation states: > > > > > > > > > > 1. Download the TCK & Unzip it [2] > > > > > 2. Set some env variables as explained in the README of [1] > > > > > 3. Run the shell script to build the > > > > > tck: $WORKSPACE/docker/build_jakartaeetck.sh > > > > > > > > > > The first task is pretty straightforward. Setting up ant as > > > > > well > > > > > as > > > > > jdk8 is also straightforward. > > > > > > > > > > However, the execution of the actual build script fails as it > > > > > seems > > > > > to > > > > > reference an "install" folder inside the "jakartaeetck" > > > > > folder, > > > > > which > > > > > does not exist by default. The output of the script is here: > > > > > [3]. > > > > > > > > > > So basically my questions are: > > > > > > > > > > 1. Did I miss something important? > > > > > 2. Is there any other or some additional documentation > > > > > (besides > > > > > the > > > > > README.adoc in [4]), which explains setting up the tck? :) > > > > > > > > > > Downloading the tck tagged as 8.0.2 directly from GitHub [5] > > > > > provides > > > > > a > > > > > rather small zip file (80MB compared to the 655MB file > > > > > mentioned > > > > > in > > > > > the > > > > > README) but contains the missing "install" directory. The > > > > > build > > > > > from > > > > > this ZIP [5] seems to work but I am quite confused now. > > > > > > > > > > Gruss & Thx > > > > > Richard > > > > > > > > > > [1] https://github.com/apache/tomee-tck > > > > > [2] > > > > > > > https://download.eclipse.org/jakartaee/platform/8/jakarta-jakartaeetck-8.0.2.zip > > > > > [3] > > > > > https://gist.github.com/rzo1/325ee0b6909b2d960db86cd38d511017 > > > > > [4] > > > > > https://github.com/apache/tomee-tck/blob/master/README.adoc > > > > > [5] > > > > > https://github.com/eclipse-ee4j/jakartaee-tck/releases/tag/8.0.2 > > > > -- > > > >
smime.p7s
Description: S/MIME cryptographic signature
