rzo1 commented on a change in pull request #777:
URL: https://github.com/apache/tomee/pull/777#discussion_r603250400
##########
File path: server/openejb-cxf/pom.xml
##########
@@ -191,7 +195,7 @@
<artifactId>jaxb-xjc</artifactId>
</exclusion>
<exclusion>
- <groupId>net.sf.ehcache</groupId>
+ <groupId>org.ehcache</groupId>
Review comment:
Good catch. Seems they upgraded `ehcache` from v2 to v3 with 3.4.x
Don't know, if this affects anything in TomEE itself as we still have
`ehcache` v2 in the classpath (at least we declare it in the root pom).
Consequently, I am wondering, if this will be an problem, if we exclude the v3
`ehcache` here`.
Might be also relevant for other libs, which come with v3 (such as
`wss4j-ws-security-stax` - exclude on `ǹet.sf` doesnt work anymore...).
Consequently, I am wondering, if we need to upgrade the `ehcache` version in
TomEE as well (would require to add `org.ehcache` to the exclusion lists in
`ContainerClassesFilter` and `JuliLogStreamFactory`).
Maybe @dblevins has some thoughts on it?
##########
File path: server/openejb-cxf/pom.xml
##########
@@ -191,7 +195,7 @@
<artifactId>jaxb-xjc</artifactId>
</exclusion>
<exclusion>
- <groupId>net.sf.ehcache</groupId>
+ <groupId>org.ehcache</groupId>
Review comment:
Might be interesting to do some `mvn dependency:tree` analysis related
to ehcache? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
