rzo1 commented on code in PR #40:
URL: 
https://github.com/apache/tomee-site-generator/pull/40#discussion_r856112499


##########
src/main/jbake/content/download.adoc:
##########
@@ -12,8 +12,8 @@ You **must** 
link:https://www.apache.org/info/verification.html[verify] the inte
 == [[tomee-9.0]]Apache TomEE 9.0
 
 - Jakarta EE 9.1
-- MicroProfile 2.0

Review Comment:
   While this change is true for the current M8-SNAPSHOT, it isn't for the 
latest M7 release, which bundles the old MP versions. In addition, it is 
compiled against Java 11 as we used byte code transformation of TomEE 8 to 
create M7. 
   
   I would suggest to drop this particular change until we have an M8 or final 
release.



##########
src/main/jbake/content/download.adoc:
##########
@@ -12,8 +12,8 @@ You **must** 
link:https://www.apache.org/info/verification.html[verify] the inte
 == [[tomee-9.0]]Apache TomEE 9.0
 
 - Jakarta EE 9.1
-- MicroProfile 2.0

Review Comment:
   While this change is true for the current M8-SNAPSHOT, it isn't for the 
latest M7 release, which bundles the old MP versions. In addition, it is 
compiled against Java 11 as we used byte code transformation of TomEE 8 to 
create M7. 
   
   I would suggest to drop this particular change until we have an M8 or final 
release.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to