tichovz commented on code in PR #891:
URL: https://github.com/apache/tomee/pull/891#discussion_r906866533
##########
examples/arquillian-jpa/pom.xml:
##########
@@ -105,6 +106,33 @@ language governing permissions and limitations under the
License. -->
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.jboss.arquillian.junit5</groupId>
+ <artifactId>arquillian-junit5-container</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.jboss.arquillian.junit5</groupId>
+ <artifactId>arquillian-junit5-core</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
+ <scope>test</scope>
+ <type>jar</type>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>4.13.2</version>
Review Comment:
Yes, we still need it, because without it a
"java.lang.ClassNotFoundException: org.junit.runners.BlockJUnit4ClassRunner"
occurs during the loading of tomee-embedded container
##########
examples/arquillian-jpa/pom.xml:
##########
@@ -28,10 +28,22 @@ language governing permissions and limitations under the
License. -->
<artifactId>maven-compiler-plugin</artifactId>
<version>3.5.1</version>
Review Comment:
Yes, we can, I ugraded the dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
