Hey Zoltán, If you want to upgrade us to the MP JWT 2.1 RC6 TCK and get that last failing test to pass, that'd be pretty cool. Basically there's a new property we have to implement.
We're all good on MP JWT 2.0 compliance, but we could claim 2.1 compliance if we get that test to pass. -David > On Oct 26, 2022, at 3:01 AM, Zoltán Tichov <[email protected]> wrote: > > Hi Jean-Louis! > > Thanks. Is there another task I can help with or should I look at JIRA > instead? > > Zoltán > > > On Wed, Oct 26, 2022 at 9:40 AM Jean-Louis Monteiro < > [email protected]> wrote: > >> Hi Zlotan, >> >> My PR is now fully green with 100% of the MicroProfile OpenTracing TCK >> passing. >> >> The changes are fairly minimal to be honest. >> There was a JAX RS Client issue with the TCK and the way it handles the >> tags, especially the http.status_code one which was converted as an Integer >> whereas the specification expects a BigDecimal. >> >> The CDI interceptor was not being picked up so nested calls in the >> application using CDI beans were not working. >> >> The first JAX RS/JSONB issue took me a while to pin down and resolve >> properly. I had to investigate the TCK change that broke it, the >> specifications and then try with Johnzon, Jackson and Resteasy/Yasson. It >> worked only with Yasson. I found a trick to make it work with Johnzon so we >> don't need to bring the world just to run TCK. >> >> -- >> Jean-Louis Monteiro >> http://twitter.com/jlouismonteiro >> http://www.tomitribe.com >> >> >> On Tue, Oct 25, 2022 at 10:02 PM Zoltán Tichov <[email protected]> >> wrote: >> >>> Hi Jean-Louis! >>> >>> I've also noticed that for many tests the expected and found results seem >>> to be the same and the test still fails. >>> >>> On Tue, Oct 25, 2022 at 9:11 PM Jean-Louis Monteiro < >>> [email protected]> wrote: >>> >>>> Hi Zlotan, >>>> >>>> Thanks for the reply. >>>> >>>> What are you trying to achieve? >>>> What is the listener doing? >>>> What kind of listener is it? >>>> >>>> Do you have maybe a branch you can share on your fork or so? >>>> >>>> FYI I found something weird in the TCK that I need to clarify. >>>> >>>> -- >>>> Jean-Louis Monteiro >>>> http://twitter.com/jlouismonteiro >>>> http://www.tomitribe.com >>>> >>>> >>>> On Tue, Oct 25, 2022 at 8:03 PM Zoltán Tichov <[email protected] >>> >>>> wrote: >>>> >>>>> Hi! >>>>> >>>>> I tried to register SmallRyeRestClientListener and I created >>>>> >>>>> >>>> >>> >> tomee/tomee-microprofile/mp-common/src/main/resources/META-INF/services/org.eclipse.microprofile.rest.client.spi.RestClientListener >>>>> file contains SmallRyeRestClientListener class name. However, it >>> doesn't >>>>> seem to work. >>>>> How can I get the listener to work? >>>>> >>>>> Thanks: >>>>> Zoltán >>>>> >>>>> On Tue, Oct 25, 2022 at 12:57 PM Jean-Louis Monteiro < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi Zlotan, >>>>>> >>>>>> I'll start a new thread to see if we can collaborate and move >> forward >>>>> with >>>>>> the MicroProfile OpenTracing support. >>>>>> >>>>>> Jean-Louis >>>>>> -- >>>>>> Jean-Louis Monteiro >>>>>> http://twitter.com/jlouismonteiro >>>>>> http://www.tomitribe.com >>>>>> >>>>>> >>>>>> On Thu, Oct 20, 2022 at 3:47 PM David Blevins < >>> [email protected]> >>>>>> wrote: >>>>>> >>>>>>> Thanks, Richard. Sorry, Zoltán, had one one of those "find this >>>>>>> attachment" and then forgot to attach. >>>>>>> >>>>>>> Here's the link I forgot to paste: >>>>>>> >>>>>>> - >>>>>>> >>>>>> >>>>> >>>> >>> >> https://github.com/apache/tomee/blob/main/tck/microprofile-tck/opentracing/src/test/resources/arquillian.xml#L29 >>>>>>> >>>>>>> As Richard mentions, here's where I'd mess with the >> <suiteXmlFiles> >>>>>>> setting for the MP JWT work: >>>>>>> >>>>>>> - >>>>>>> >>>>>> >>>>> >>>> >>> >> https://github.com/apache/tomee/blob/main/tck/microprofile-tck/jwt/pom.xml#L189 >>>>>>> >>>>>>> I would basically temporarily edit that line to this value >>>>>>> `<suiteXmlFile>tck-base-suite.xml</suiteXmlFile>` and then go >> into >>>> this >>>>>>> file and comment out everything but the test I wanted to run: >>>>>>> >>>>>>> - >>>>>>> >>>>>> >>>>> >>>> >>> >> https://github.com/apache/tomee/blob/main/tck/microprofile-tck/jwt/tck-base-suite.xml >>>>>>> >>>>>>> For opentracing here is where you'd edit: >>>>>>> >>>>>>> - >>>>>>> >>>>>> >>>>> >>>> >>> >> https://github.com/apache/tomee/blob/main/tck/microprofile-tck/opentracing/pom.xml#L36-L40 >>>>>>> - >>>>>>> >>>>>> >>>>> >>>> >>> >> https://github.com/apache/tomee/blob/main/tck/microprofile-tck/opentracing/tck-dev.xml#L22 >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> David Blevins >>>>>>> http://twitter.com/dblevins >>>>>>> http://www.tomitribe.com >>>>>>> >>>>>>>> On Oct 20, 2022, at 1:14 AM, Zowalla, Richard < >>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>> Hi Zoltan, >>>>>>>> >>>>>>>> the arquillian config is located in >>>>>>>> /src/test/java/resources/arquillian.xml. >>>>>>>> >>>>>>>> In this file, you can find a "debug" property, which you can >> set >>> to >>>>>>>> "true" to enable the debug capabilities of TomEE (i.e. start >>> with a >>>>>>>> debugger backend). >>>>>>>> >>>>>>>> You can debug single tests by editing "tck-dev.xml" in the >> module >>>>> root >>>>>>>> directory and adjust the surefire config to use it: >>>>>>>> >>>>>>>> <suiteXmlFiles> >>>>>>>> <suiteXmlFile>tck-dev.xml</suiteXmlFile> >>>>>>>> </suiteXmlFiles> >>>>>>>> >>>>>>>> Hope it helps >>>>>>>> >>>>>>>> Gruß >>>>>>>> Richard >>>>>>>> >>>>>>>> Am Donnerstag, dem 20.10.2022 um 09:07 +0200 schrieb Zoltán >>> Tichov: >>>>>>>>> Hi! >>>>>>>>> >>>>>>>>> I have not been able to solve this problem: >>>>>>>>> >>>>>>>>> ERROR: transport error 202: connect failed: Connection refused >>>>>>>>> ERROR: JDWP Transport dt_socket failed to initialize, >>>>>>>>> TRANSPORT_INIT(510) >>>>>>>>> JDWP exit error AGENT_ERROR_TRANSPORT_INIT(197): No transports >>>>>>>>> initialized >>>>>>>>> [./src/jdk.jdwp.agent/share/native/libjdwp/debugInit.c:735] >>>>>>>>> >>>>>>>>> "Set this property to `true` and it should start TomEE with >>> debug >>>>>>>>> enabled >>>>>>>>> and listening to port 5005." >>>>>>>>> >>>>>>>>> Where should this be set? I looked at the other microprofile >> TCK >>>>>>>>> implementations, but couldn't find a solution >>>>>>>>> >>>>>>>>> I managed to activate the opentracing interceptor, but the >> tests >>>> are >>>>>>>>> still >>>>>>>>> red. I'm still looking for what else needs to be implemented >> to >>>> make >>>>>>>>> the >>>>>>>>> tests work. >>>>>>>>> >>>>>>>>> Thanks: >>>>>>>>> >>>>>>>>> Zoltán >>>>>>>>> >>>>>>>>> >>>>>>>>> On Tue, Oct 11, 2022 at 6:48 PM David Blevins >>>>>>>>> <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>>> On Oct 11, 2022, at 5:53 AM, Zoltán Tichov >>>>>>>>>>> <[email protected]> >>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> How to activate the OpenTracingInterceptor from >>>>>>>>>>> org.apache.tomee.microprofile.opentracing package? >>>>>>>>>> >>>>>>>>>> Set this property to `true` and it should start TomEE with >>> debug >>>>>>>>>> enabled >>>>>>>>>> and listening to port 5005. >>>>>>>>>> >>>>>>>>>>> I think I overestimated my knowledge for this task, so if >> you >>>>>>>>>>> think so, I >>>>>>>>>>> would rather pass this task. On the other hand, if there is >>>> still >>>>>>>>>>> time, I >>>>>>>>>>> would like to deal with this. >>>>>>>>>> >>>>>>>>>> Take another week and see how far you get. There's great >> value >>>> in >>>>>>>>>> having >>>>>>>>>> more people able to help with TCK work. It's definitely >> worth >>> it >>>>>>>>>> for us >>>>>>>>>> all to make the effort to help others get in there and be >>>>>>>>>> effective. >>>>>>>>>> >>>>>>>>>> Anything but silence is good progress. Silence is the kiss >> of >>>>>>>>>> death for >>>>>>>>>> tasks like this -- just so much knowledge to transfer. I >> don't >>>>>>>>>> think >>>>>>>>>> there's a human being on planet earth who could go from "I >> want >>>> to >>>>>>>>>> help get >>>>>>>>>> this TCK to pass" to "here's a PR for a passing TCK" and no >>>>>>>>>> questions in >>>>>>>>>> the middle. >>>>>>>>>> >>>>>>>>>> Certainly, I needed a ton of help and I've never met anyone >> who >>>>>>>>>> didn't. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -David >>>>>>>>>> >>>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >>
smime.p7s
Description: S/MIME cryptographic signature
