rzo1 commented on code in PR #953:
URL: https://github.com/apache/tomee/pull/953#discussion_r1016594940
##########
pom.xml:
##########
@@ -1341,7 +1327,7 @@
<dependency>
<groupId>org.apache.geronimo.mail</groupId>
<artifactId>geronimo-mail_2.1_provider</artifactId>
- <version>${geronimo-mail_2.1_provider.version}</version>
+ <version>${version.geronimo-javamail_1.6_mail}</version>
Review Comment:
This version string doesn't look right? Might explain my confusion regarding
one of the dropped properties.
##########
pom.xml:
##########
@@ -102,28 +101,16 @@
<version.jakartaee-api>9.1-M2</version.jakartaee-api>
<version.tomee-patch-plugin>0.9</version.tomee-patch-plugin>
- <!--
- JavaMail is both API and IMPL so we don't have them in the jakartaee-api
uber jar.
- We decided to add them here in the project so we can patch/update the 2
libraries without having
- to update and release the jakartaee-api.jar. Different lifecycle.
- -->
- <geronimo-mail_2.1_spec.version>1.0.0-M1</geronimo-mail_2.1_spec.version>
-
<geronimo-mail_2.1_provider.version>1.0.0</geronimo-mail_2.1_provider.version>
Review Comment:
Any reason for dropping one of these versions? Guess we need to check, what
is needed / required.
##########
pom.xml:
##########
@@ -102,28 +101,16 @@
<version.jakartaee-api>9.1-M2</version.jakartaee-api>
<version.tomee-patch-plugin>0.9</version.tomee-patch-plugin>
- <!--
- JavaMail is both API and IMPL so we don't have them in the jakartaee-api
uber jar.
- We decided to add them here in the project so we can patch/update the 2
libraries without having
Review Comment:
Guess we should keep these comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
