Hi Benedict, just checked out your branch and run it locally. Seems to work. I quickly screened the PR and added some comments.
Regarding the "user" stuff: I think, we just need to configure it. Maybe have a look here: - https://github.com/apache/tomee-tck/blob/tomee-10-with-ee-91/src/test/tomee-plume/conf/tomcat-users.xml and here: - https://github.com/apache/tomee-tck/blob/tomee-10-with-ee-91/src/test/resources/testsuite.properties - https://github.com/apache/tomee-tck/blob/tomee-10-with-ee-91/src/test/tomee-plume/conf/system.properties - https://github.com/apache/tomee-tck/blob/tomee-10-with-ee-91/src/test/tomee-plume/conf/cxf.properties In addition, we need to add the cxf property to use the old conduit due to limitation with the newer one: https://github.com/apache/tomee-tck/commit/8ddc037c8bb3b8f8619a189dc271953241463b88 Gruß Richard Am Dienstag, dem 05.09.2023 um 22:58 +0200 schrieb Benedict Eisenkrämer: > Hi Richard, > > I have created a PR, for now with the copied files. > > I am currently trying to run the tests with the staging repositories > dependency, which seems to work. > I think that would be acceptable at the moment, as we are still in > development? > > Gruß Benedict > > On 05.09.23 21:44, Richard Zowalla wrote: > > Hey Benedict, > > > > seems they are still working on it. It is available for 3.1.3-1 in > > their staging repo: https://github.com/jakartaee/rest/issues/1142 > > > > Gruß > > Richard > > > > Am Montag, dem 04.09.2023 um 18:02 +0200 schrieb Benedict > > Eisenkrämer: > > > Sounds good to me, I will try to create one tomorrow. > > > About the maven artifact, I actually had the same plan there, yet > > > could > > > not find one: > > > > > > * It is not listed on the specification-site: > > > https://jakarta.ee/specifications/restful-ws/3.0/ > > > * It is not listed in mvn central: > > > https://mvnrepository.com/artifact/jakarta.ws > > > * Some google searches yielded no results as well > > > > > > Maybe you or someone else has an idea where to look or could > > > enlighten me. > > > > > > > > > On 04.09.23 17:27, Richard Zowalla wrote: > > > > Hi Benedict, > > > > > > > > perhaps worth to create a PR with the setup targeting the main > > > > branch, so it is part > > > > ofhttps://github.com/apache/tomee/tree/main/tck ? > > > > > > > > There might be a Maven artifact available, so we don't need to > > > > copy/paste the sources. > > > > > > > > Gruß > > > > Richard > > > > > > > > > > > > > > > > Am 18. August 2023 19:20:24 MESZ schrieb "Benedict > > > > Eisenkrämer"<bened...@eisenkramer.de>: > > > > > Small correction, I meant Richards-Branch, he shared in an > > > > > other > > > > > thread: > > > > > https://github.com/rzo1/tomee/tree/cxf4 > > > > > > > > > > > > > > > On 18.08.23 19:15, Benedict Eisenkrämer wrote: > > > > > > Hi, > > > > > > > > > > > > I now have a kind of working setup for the tck, related to > > > > > > this > > > > > > ticket:https://issues.apache.org/jira/browse/TOMEE-4166 > > > > > > The setup tests against this modified main-branch of the > > > > > > tomee- > > > > > > repository:https://github.com/Sollder11/tomee > > > > > > I only changed a few things with the embedded-tomee there. > > > > > > My current tck-setup can be found > > > > > > here: > > > > > > https://gitlab.com/Sollder1/tomee-10-jaxrs-tck-setup-tests > > > > > > > > > > > > My last result was: > > > > > > [INFO] > > > > > > [INFO] Results: > > > > > > [INFO] > > > > > > [ERROR] Failures: > > > > > > [ERROR] JAXRSClientIT.<init>:59->usersetup:97 > > > > > > user > > > > > > not set ==> expected: <true> but was: <false> > > > > > > [ERROR] JAXRSClientIT.<init>:59->usersetup:97 > > > > > > user > > > > > > not set ==> expected: <true> but was: <false> > > > > > > [ERROR] JAXRSBasicClientIT.<init>:59->JAXRSClient.setup:53 > > > > > > user > > > > > > was not set ==> expected: <true> but was: <false> > > > > > > [ERROR] JAXRSBasicClientIT.<init>:59->JAXRSClient.setup:53 > > > > > > user > > > > > > was not set ==> expected: <true> but was: <false> > > > > > > [ERROR] JAXRSBasicClientIT.<init>:59->JAXRSClient.setup:53 > > > > > > user > > > > > > was not set ==> expected: <true> but was: <false> > > > > > > [ERROR] JAXRSBasicClientIT.<init>:59->JAXRSClient.setup:53 > > > > > > user > > > > > > was not set ==> expected: <true> but was: <false> > > > > > > [ERROR] JAXRSBasicClientIT.<init>:59->JAXRSClient.setup:53 > > > > > > user > > > > > > was not set ==> expected: <true> but was: <false> > > > > > > [ERROR] JAXRSClientIT.sseBroadcastTest:193- > > > > > > > JAXRSCommonClient.assertEquals:721 > > > > > > [Ljava.lang.Object;@43a8dd9b ==> expected: <true> but was: > > > > > > <false> > > > > > > [ERROR] JAXRSClientIT.dynamicFeatureIsRegisteredTest:111- > > > > > > > JAXRSCommonClient.assertEquals:721 > > > > > > [Ljava.lang.Object;@7b8f8de5 ==> expected: <true> but was: > > > > > > <false> > > > > > > [ERROR] JAXRSClientIT.featureIsRegisteredTest:93- > > > > > > > JAXRSCommonClient.assertEquals:721 > > > > > > [Ljava.lang.Object;@6c4cfe0e ==> expected: <true> but was: > > > > > > <false> > > > > > > [ERROR] Errors: > > > > > > [ERROR] > > > > > > JAXRSClientIT.clientSideReaderIsNotUsedOnServerTest:124- > > > > > > > JaxrsCommonClient.invoke:219 » Fault > > > > > > [ERROR] > > > > > > JAXRSClientIT.clientSideReaderIsUsedOnClientTest:195- > > > > > > > JaxrsCommonClient.invoke:219 » Fault > > > > > > [ERROR] > > > > > > JAXRSClientIT.clientSideWriterIsNotUsedOnServerTest:159- > > > > > > > JaxrsCommonClient.invoke:219 » Fault > > > > > > [ERROR] > > > > > > JAXRSClientIT.clientSideWriterIsUsedOnClientTest:234- > > > > > > > JaxrsCommonClient.invoke:219 » Fault > > > > > > [ERROR] > > > > > > JAXRSClientIT.serverSideReaderIsNotUsedOnClientTest:177- > > > > > > > JaxrsCommonClient.invoke:219 » Fault > > > > > > [ERROR] > > > > > > JAXRSClientIT.serverSideReaderIsUsedOnServerTest:107- > > > > > > > JaxrsCommonClient.invoke:219 » Fault > > > > > > [ERROR] > > > > > > JAXRSClientIT.serverSideWriterIsNotUsedOnClientTest:213- > > > > > > > JaxrsCommonClient.invoke:219 » Fault > > > > > > [ERROR] > > > > > > JAXRSClientIT.serverSideWriterIsUsedOnServerTest:141- > > > > > > > JaxrsCommonClient.invoke:219 » Fault > > > > > > [ERROR] > > > > > > SeBootstrapIT.shouldBootInstanceDespiteUnknownConfiguration > > > > > > Para > > > > > > meters:236 » AbstractMethod > > > > > > [ERROR] > > > > > > SeBootstrapIT.shouldBootInstanceUsingConvenienceMethods:148 > > > > > > » AbstractMethod R... > > > > > > [ERROR] > > > > > > SeBootstrapIT.shouldBootInstanceUsingDefaults:71 » > > > > > > AbstractMethod Receiver cla... > > > > > > [ERROR] > > > > > > SeBootstrapIT.shouldBootInstanceUsingExternalConfiguration: > > > > > > 186 > > > > > > » AbstractMethod > > > > > > [ERROR] > > > > > > SeBootstrapIT.shouldBootInstanceUsingImplementationsDefault > > > > > > IpPo > > > > > > rt:317 » AbstractMethod > > > > > > [ERROR] > > > > > > SeBootstrapIT.shouldBootInstanceUsingProperties:107 » > > > > > > AbstractMethod Receiver ... > > > > > > [ERROR] > > > > > > SeBootstrapIT.shouldBootInstanceUsingSelfDetectedFreeIpPort > > > > > > :280 > > > > > > » AbstractMethod > > > > > > [ERROR] JAXRSSigTestIT.signatureTest:412 Fault > > > > > > JAXRSSigTestIT.signatureTest() failed!,... > > > > > > [INFO] > > > > > > [ERROR] Tests run: 2796, Failures: 10, Errors: 16, Skipped: > > > > > > 128 > > > > > > [INFO] > > > > > > > > > > > > The full result may be found > > > > > > here: > > > > > > https://gitlab.com/Sollder1/tomee-10-jaxrs-tck-setup-tests > > > > > > /-/tree/main/runs/sollder1/_18082023_1903?ref_type=heads > > > > > > > > > > > > As can be expected the tests for the new SE-Bootstrap fail, > > > > > > as > > > > > > this is a new feature in JakartaEE10. > > > > > > Also all the Authorization / Security Tests fail, I do not > > > > > > really get what to do there ,as the documentation is rather > > > > > > vague here. > > > > > > The other issues may very well be related to the fact, that > > > > > > the > > > > > > cxf-version used is not actually compatible. > > > > > > > > > > > > Some feedback/inside would be very much appreciated. > > > > > > > > > > > > I will try to run against the Roberts branch next, which > > > > > > already includes the newest cxf version and seems to have > > > > > > only > > > > > > four failures with the old tck. > > > > > > I think this should result in a few more tests succeeding, > > > > > > although cxf4 is not yet fully JakartaEE10 compatible. > > > > > > > > > > > > Gruß Benedict >
signature.asc
Description: This is a digitally signed message part
