rmannibucau commented on code in PR #990:
URL: https://github.com/apache/tomee/pull/990#discussion_r1398970401
##########
mp-jwt/src/main/java/org/apache/tomee/microprofile/jwt/config/JWTAuthConfigurationProperties.java:
##########
@@ -117,6 +119,15 @@ private JWTAuthConfiguration createJWTAuthConfiguration() {
config.getOptionalValue("mp.jwt.decrypt.key.algorithm",
String.class).orElse(null),
config.getOptionalValue("mp.jwt.verify.publickey.algorithm",
String.class).orElse(null));
}
+
+ private Boolean queryAllowExp(){
Review Comment:
```
private Boolean queryAllowExp(){
return config.getOptionalValue("tomee.mp.jwt.allow.no-exp",
Boolean.class)
.or(() ->
config.getOptionalValue("mp.jwt.tomee.allow.no-exp", Boolean.class)
.map(value -> {
CONFIGURATION.warning("mp.jwt.tomee.allow.no-exp
property is deprecated, use tomee.mp.jwt.allow.no-exp propert instead.");
return value;
}))
.orElse(false);
}
```
to avoid to read both entries all the time (`Config` can be slow depending
the `ConfigSource`) and to avoid the `AtomicBoolean` which is not needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
