rzo1 commented on code in PR #1165: URL: https://github.com/apache/tomee/pull/1165#discussion_r1611564278
########## arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/GreetingController.java: ########## @@ -0,0 +1,19 @@ +package org.apache.openejb.arquillian.tests.jaxrs.spring; Review Comment: Missing header ########## arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/DemoApplication.java: ########## @@ -0,0 +1,13 @@ +package org.apache.openejb.arquillian.tests.jaxrs.spring; Review Comment: Missing header ########## arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/AlternativeGreeter.java: ########## @@ -0,0 +1,22 @@ +package org.apache.openejb.arquillian.tests.jaxrs.spring; Review Comment: Missing header ########## arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/ServletInitializer.java: ########## @@ -0,0 +1,13 @@ +package org.apache.openejb.arquillian.tests.jaxrs.spring; Review Comment: Missing header ########## arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/resources/spring-webmvc-pom.xml: ########## @@ -0,0 +1,44 @@ +<?xml version="1.0" encoding="UTF-8"?> Review Comment: Missing header ########## arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/resources/spring-webmvc-pom.xml: ########## @@ -0,0 +1,44 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.springframework.boot</groupId> + <artifactId>spring-boot-starter-parent</artifactId> + <version>3.1.11</version> Review Comment: Spring Boot 3 has a Java 17 baseline, so this will likely fail the Java 11 based build. I think, that we would need to build an exclusion for that test if we run with a runtime below 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
