I've only had a change to take a cursory look at the PR, but I was immediately impressed.
I can't thank you enough -- what an amazing undertaking! It might be crickets getting a review for a PR that big especially given our starved state, so as long as you're a good sport about changes to the code after it's merged I suspect we should just merge it and see what breaks. Totally ok to leave it open for a bit as well. What an amazing contribution, Markus. Seriously. Huge applause. -David > On Jun 2, 2024, at 8:34 AM, Markus Jung <ju...@apache.org> wrote: > > Hi all, > > small update after a long time of silence, my implementation now passes the > (admittedly very few) openid tests in the TCK: > [INFO] Reactor Summary for Jakarta Security TCK - main 3.0.1: > [INFO] > [INFO] Jakarta Security TCK - main ........................ SUCCESS [ 2.725 > s] > [INFO] common ............................................. SUCCESS [ 0.748 > s] > [INFO] app-openid ......................................... SUCCESS [ 6.556 > s] > [INFO] app-openid2 ........................................ SUCCESS [ 15.742 > s] > [INFO] app-openid3 ........................................ SUCCESS [ 14.100 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 39.986 s > [INFO] Finished at: 2024-06-02T17:24:15+02:00 > [INFO] > ------------------------------------------------------------------------ > > > I've opened a pull request in the meantime here > https://github.com/apache/tomee/pull/1178 to gather some feedback, the > implementation is pretty much done IMO. > However I'd like to add more unit/integration tests and clean up the code a > bit more, that's why I'm keeping the PR in draft state for now. > > > Thanks > > Markus > >> On 20. Apr 2024, at 16:13, Richard Zowalla <r...@apache.org> wrote: >> >> Cool! Thanks, Markus! >> Feel free to ask any question you might come across while implementing! >> >> Am Freitag, dem 19.04.2024 um 17:14 +0200 schrieb Markus Jung: >>> Hey all, >>> >>> just a quick heads up, i've began trying to work on this a couple of >>> days ago here: https://github.com/jungm/tomee/tree/openid >>> >>> It's still a huge work in progress right now though >>> >>> >>>> On 13. Apr 2024, at 20:29, Richard Zowalla <r...@apache.org> wrote: >>>> >>>> Hi, >>>> >>>> looks like we need to implement OpenID connect for Jakarta Security >>>> 3.0 >>>> >>>> - https://jakarta.ee/specifications/security/3.0/ >>>> >>>> If anyone wants to jump in and dive into the spec -> feel free :) >>>> >>>> Gruß >>>> Richard >>> >> >
