rzo1 commented on PR #1232: URL: https://github.com/apache/tomee/pull/1232#issuecomment-2210239887
LGTM, too :) - thanks @rmannibucau for review, feedback and (long) explanation. It is really appreciated! The CI gave some test failures originating from the change: ``` Testergebnis (20 fehlgeschlagene Tests / +18) org.apache.openejb.arquillian.ManagedExecutorServiceGetPrincipalInTaskTest.run org.apache.openejb.config.BuiltInEnvironmentEntriesTest.testRed org.apache.openejb.config.BuiltInEnvironmentEntriesTest.testBlue org.apache.openejb.threads.CompletableFutureTest.testSupplyAsyncAndCompleteExceptionally org.apache.openejb.threads.CompletableFutureTest.testSupplyAsync org.apache.openejb.threads.CompletableFutureTest.testRunAsync org.apache.openejb.threads.InjectionTest.checkUserTransactionIsAccessible org.apache.openejb.threads.InjectionTest.checkInjections org.apache.openejb.threads.ManagedExecutorServiceTest.checkCdiContext org.apache.openejb.threads.ManagedExecutorServiceTest.runnable org.apache.openejb.threads.ManagedExecutorServiceTest.checkEjbContext org.apache.openejb.threads.SecurityPropagationTest.checkItIsTrue org.apache.openejb.server.cxf.rs.SuspendedTest.run org.superbiz.executor.ManagedScheduledServiceTest.singleFixedDelayTaskWithException org.superbiz.executor.ManagedScheduledServiceTest.singleFixedDelayTask org.superbiz.executor.ManagedScheduledServiceTest.periodicFixedDelayTaskWithException org.superbiz.executor.ManagedScheduledServiceTest.periodicFixedDelayTask org.superbiz.executor.ManagedServiceTest.managedInvocationTest org.superbiz.executor.ManagedServiceTest.managedInvocationTestWithException org.superbiz.executor.ManagedServiceTest.managedInvocationTestWithTimeout ``` Full logs here: https://ci-builds.apache.org/job/Tomee/view/tomee-10.x/job/pull-request-manual/113/#showFailuresLink FYI: @jungm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
