jungm opened a new pull request, #1469:
URL: https://github.com/apache/tomee/pull/1469

   SXC has not seen any changes for the past 11 years 
(https://github.com/dblevins/sxc) and only has been working in TomEE because of 
it being shaded. However the maven plugin is not really usable anymore in the 
jakarta world nowadays.
   
   @rzo1 created a fork of SXC [here](https://github.com/rzo1/sxc) that has 
been upgraded to work with Jakarta XML Binding 4.0. This PR integrates this 
fork into tomee, drops the sxc shade and includes some changes in the JAXB 
Models to fix SXC accessor generation
   
   IMO there are 3 topics:
   - Switch to @rzo1's fork? Maybe we can merge with david's code and release 
that? (cc @dblevins)
   - I added @XmlAnyAttribute to JAXB models (SXC generated code was modified 
by hand before) as tests failed. We need to double check I did not miss anything
   - After this the generated SXC accessors 100% match the JAXB models. Should 
we drop `openejb-jee-accessors` and move them to somewhere like 
`openejb-jee/target/generated-sources`? Would remove a lot of code from the 
tomee repo (just look at the diff size :wink:) and force future developers to 
not modify generated code but its source instead


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to