Thank you :) On Wed, Oct 23, 2024 at 7:36 PM Richard Zowalla <r...@apache.org> wrote:
> Alright. I saw the changes and just fixed the rat stuff (and the EE api > version) :) > > For the list, the following tests are failing and are currently disabled: > > ERROR] AvoidConflictWithWebXmlTest.filterOrder:84 expected:<[I'm the > first]> but was:<[JSP 5]> > [ERROR] AvoidConflictWithWebXmlTest.jaxrs:64 expected:<[resource]> but > was:<[JSP 5]> > [ERROR] AvoidConflictWithWebXmlWithNoResourceMatchingTest.filterOrder:87 > expected:<[I'm the first]> but was:<[JSP 5]> > [ERROR] AvoidConflictWithWebXmlWithNoResourceMatchingTest.home Expected > exception: java.io.FileNotFoundException > [ERROR] AvoidConflictWithWebXmlWithNoResourceMatchingTest.jaxrs:65 > expected:<[resource]> but was:<[JSP 5]> > [ERROR] AvoidConflictWithWebXmlWithNoResourceMatchingTest.jsp Expected > exception: java.io.FileNotFoundException > [ERROR] > > AvoidConflictWithWebXmlWithNoResourceMatchingWithRestSubPathTest.filterOrder:92 > expected:<[I'm the first]> but was:<[JSP 5]> > [ERROR] > AvoidConflictWithWebXmlWithNoResourceMatchingWithRestSubPathTest.jaxrs:72 > expected:<[resource]> but was:<[JSP 5]> > > Gruß > Richard > > > > Am 23.10.2024 um 12:27 schrieb Jonathan Gallimore < > jonathan.gallim...@gmail.com>: > > > > I've pushed something. It introduces a "functional-test" module: > > https://github.com/apache/tomee/tree/main/arquillian/functional-tests > > > > The idea here is that if we want to add a functional test to prevent a > > regression like this one, but it doesn't quite fit elsewhere, it can go > > here. ActiveMQ, for example, has a unit-tests module in addition to > > src/test for each module: > > https://github.com/apache/activemq/tree/main/activemq-unit-tests > > > > We've previously (a very long time ago) discussed that examples are > useful, > > but shouldn't be the place for regression tests. > > > > I'm ok with changing this structure around though. > > > > I've additionally added an @Ignore to some tests that fail (at least > > locally). I'll work on fixing those (the intention is not that they > remain > > ignored). > > > > Jon > > > > On Tue, Oct 22, 2024 at 6:07 PM Richard Zowalla <rich...@zowalla.com> > wrote: > > > >> Example sounds good to me. They cover a few cases, we do not have > >> elsewhere and I Bet a few people like to usw TomEE with Spring. > >> > >> Am 22. Oktober 2024 14:20:17 MESZ schrieb Jonathan Gallimore < > >> jonathan.gallim...@gmail.com>: > >>> I should clarify, the presence of > >>> > >>> <dependency> > >>> <groupId>org.springframework.boot</groupId> > >>> <artifactId>spring-boot-starter-test</artifactId> > >>> <version>3.1.11</version> > >>> <scope>test</scope> > >>> </dependency> > >>> > >>> Stops *all* the JAX-RS tests running. This exclude fixes it: > >>> > >>> <dependency> > >>> <groupId>org.springframework.boot</groupId> > >>> <artifactId>spring-boot-starter-test</artifactId> > >>> <version>3.1.11</version> > >>> <scope>test</scope> > >>> <exclusions> > >>> <exclusion> > >>> <groupId>org.junit.jupiter</groupId> > >>> <artifactId>junit-jupiter</artifactId> > >>> </exclusion> > >>> <exclusion> > >>> <groupId>org.junit.jupiter</groupId> > >>> <artifactId>junit-jupiter-api</artifactId> > >>> </exclusion> > >>> </exclusions> > >>> </dependency> > >>> > >>> but I do wonder if this is better tested in a module elsewhere > (something > >>> like an example, maybe?). There seems to be other issues around that > >>> SpringWebappTest which I'm digging into. > >>> > >>> Jon > >>> > >>> On Tue, Oct 22, 2024 at 1:17 PM Jonathan Gallimore < > >>> jonathan.gallim...@gmail.com> wrote: > >>> > >>>> Actually, TomEE 10 / main. I would like to backport that change to > 9.x, > >>>> and understand the Java 17 issue there. I haven't tested, but I guess > >>>> compilation with Java 11 might also fail there (so a separate module > may > >>>> help there too). > >>>> > >>>> On Tue, Oct 22, 2024 at 1:07 PM Richard Zowalla <rich...@zowalla.com> > >>>> wrote: > >>>> > >>>>> Is this about the 9.x branch? If so, the reason is, that Spring > >> requires > >>>>> a Java 17 baseline. > >>>>> > >>>>> Am 22. Oktober 2024 12:06:08 MESZ schrieb Jonathan Gallimore < > >>>>> jonathan.gallim...@gmail.com>: > >>>>>> I've noticed that the dependencies for this test cause the test > suite > >> for > >>>>>> arquillian-tomee-jaxrs-tests not to run. > >>>>>> > >>>>>> Even after fixing that, it looks like there are still issues. I'm > >>>>> thinking > >>>>>> of pulling this into its own module (still under Arquillian TomEE > >> Tests) > >>>>>> for anything that we might want to test with Spring. > >>>>>> > >>>>>> Any thoughts? > >>>>>> > >>>>>> Jon > >>>>> > >>>> > >> > >
