jungm commented on code in PR #1: URL: https://github.com/apache/tomee-quartz-shade/pull/1#discussion_r1908766537
########## README.adoc: ########## @@ -0,0 +1,11 @@ +http://www.apache.org/licenses/LICENSE-2.0.html[image:http://img.shields.io/:license-apache-blue.svg[License]] + +== Apache TomEE - Quart Shade Review Comment: typo ########## pom.xml: ########## @@ -17,64 +17,104 @@ limitations under the License. --> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> + <parent> <groupId>org.apache</groupId> <artifactId>apache</artifactId> - <version>14</version> + <version>33</version> + <relativePath><!--Resolve on repository--></relativePath> </parent> + <modelVersion>4.0.0</modelVersion> - <groupId>org.apache.openejb.shade</groupId> - <artifactId>quartz-openejb-shade</artifactId> - <version>2.2.5-SNAPSHOT</version> - <name>OpenEJB :: Dependencies :: Quartz Shade</name> + <groupId>org.apache.tomee.shade</groupId> + <artifactId>tomee-quartz-shade</artifactId> + <version>2.5.0-SNAPSHOT</version> + <name>Apache TomEE :: Dependencies :: Quartz Shade</name> <scm> - <connection>scm:svn:https://svn.apache.org/repos/asf/tomee/deps/trunk/quartz-openejb-shade</connection> - <developerConnection>scm:svn:https://svn.apache.org/repos/asf/tomee/deps/trunk/quartz-openejb-shade - </developerConnection> - <url>http://svn.apache.org/viewvc/tomee/deps/trunk/quartz-openejb-shade/</url> + <connection>scm:git:https://git-wip-us.apache.org/repos/asf/quartz-openejb-shade.git</connection> Review Comment: should be gitbox.apache.org -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org