I did commit a fix for that test: https://github.com/apache/tomee/commit/26a0cff65b4649040709526197e57330b7e21743, so hopefully that's now ok. I could also remove this check: https://github.com/apache/tomee/blob/main/container/openejb-core/src/main/java/org/apache/openejb/core/ThreadContext.java#L49, as it might be a bit aggressive, but theoretically, we shouldn't run into that condition, and if we do, we need to fix the calls to ThreadContext.enter() and exit().
Jon On Mon, Sep 15, 2025 at 3:45 PM Markus Jung <ju...@apache.org> wrote: > Hey Jon, > > I was seeing this failure in > org.apache.openejb.core.security.IsLoggedTest#isLogged a couple days ago > about a ThreadContext being entered twice before committing Tomcat 10.1.46, > I couldn’t reproduce it on my machine so just committed Tomcat 10.1.46 and > re-ran the full build which is now green too. > > Guess that is a somewhat flaky test? > > Thanks > Markus > > > On 15. Sep 2025, at 16:26, Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > > > Build #1912 looks ok - are you seeing failures I'm missing? > > > > Thanks > > > > Jon > > > > On Sat, Sep 13, 2025 at 7:49 PM Richard Zowalla <r...@apache.org> wrote: > > > >> Hi Jon, > >> > >> Looks like the last changes broke the build. Can you have a look? > >> > >> Gruß > >> Richard > >> > >>> Am 09.09.2025 um 19:18 schrieb Jonathan Gallimore < > >> jonathan.gallim...@gmail.com>: > >>> > >>> Thanks! I have managed to get it pushed, along with a unit test change. > >>> I've run the build locally and it looks ok - I'll keep an eye on the > CI. > >>> > >>> Thanks > >>> > >>> Jon > >>> > >>> On Tue, Sep 9, 2025 at 11:24 AM Markus Jung <ju...@apache.org> wrote: > >>> > >>>> Sure thing, no need to rush. I won't run a release for at least ~3 > days > >>>> anyways since Tomcat 10.1.45 has some issues with FileStore session > >>>> storage (see announcement > >>>> https://lists.apache.org/thread/k4h4nxphq547rdw31q13cx2d0rz0r2l1) > and a > >>>> 10.1.46 vote is already running > >>>> > >>>> > >>>> On 9/9/25 11:32, Jonathan Gallimore wrote: > >>>>> I've got a fix for a concurrency bug that I'd like to get in today if > >>>>> that's possible. The issue is here: > >>>>> > >>>> > >> > https://github.com/apache/tomee/blob/main/container/openejb-core/src/main/java/org/apache/openejb/threads/impl/ApplicationThreadContextProvider.java#L76 > >>>>> where we allow at ThreadContext to be entered twice. Not entirely > sure > >>>> how > >>>>> to best test it, but I'll try and get something committed today. > >>>>> > >>>>> Jon > >>>>> > >>>>> On Mon, Sep 8, 2025 at 9:13 AM Markus Jung <ju...@apache.org> wrote: > >>>>> > >>>>>> Hey all, > >>>>>> > >>>>>> > >>>>>> Thomas reported a bug in deploying the @FacesBehavior JSF annotation > >>>>>> (TOMEE-4524) that causes current PrimeFaces SNAPSHOT builds to not > run > >>>>>> on TomEE. This directly affects us as a TomEE user because we build > >>>>>> PrimeFaces from the master branch whenever we contribute > >> features/fixes, > >>>>>> so I'd like to run a release for 10.1.2 rather sooner than later. > >>>>>> > >>>>>> Other than that nothing too exciting happened since 10.1.1, just a > few > >>>>>> dependency updates. There is an ongoing VOTE for Tomcat 10.1.45 > >>>>>> (https://lists.apache.org/thread/j4htrl5plgrdn1n4gvcfn3x247rtk3l5) > >> that > >>>>>> we should IMO be waiting for before we run a release. > >>>>>> > >>>>>> > >>>>>> WDYT? > >>>>>> > >>>>>> > >>>>>> Thanks > >>>>>> > >>>>>> Markus > >>>>>> > >>>>>> > >>>> > >> > >> > >
