sbp commented on issue #92: URL: https://github.com/apache/tooling-trusted-release/issues/92#issuecomment-2891494888
Issue #94 proposes adding a property to indicate whether `Revision` rows are mutable or immutable, to protect against race conditions. This does not help with the present issue, #92, because we still require allocations to take mutable revisions into account. Consider revision 1 (immutable), and then revision 2 (mutable) being created from it. We create another revision meanwhile, revision 3 (mutable), from revision 1. Revision 2 then fails in its operation, and let's say we deleted it to satisfy #92. Then the problem is that if revision 3 was successful, it's now immutable but revision 2 is no longer allocated. We always use the highest N, not the highest unallocated N, to create a new revision, so this shouldn't be a problem, but it's not very intuitive in the user interface and it's not a good idea to leave dangerous holes around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tooling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tooling.apache.org For additional commands, e-mail: dev-h...@tooling.apache.org
