sbp commented on issue #160: URL: https://github.com/apache/tooling-trusted-release/issues/160#issuecomment-2985402745
There were a few possible ways to fix this, in the scenario where there are no files in the draft: 1. Do not show the button to start the vote, and make the voting page raise an exception if accessed. 2. Retain the button to show the vote, but show an error on the vote form page instead of the form. 3. Retain the button to show the vote, but flash an error on the draft page when the button is pressed. I've chosen the third as being the most user friendly, as the first way would make it less clear what needs to be done, and the second way means that the user has to navigate back to the place where they can fix the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tooling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tooling.apache.org For additional commands, e-mail: dev-h...@tooling.apache.org
