sbp opened a new issue, #287: URL: https://github.com/apache/tooling-trusted-releases/issues/287
API payload validation is handled by `quart_schema`, and is automated and consistent. Our HTML forms are not like that, and we need to improve them. We take a relatively _ad hoc_ approach of re-rendering the originally requested form page in case of errors with validation errors displayed next to each individual field, and a summary flashed at the top of the page. This is great UI for users, but we don't implement this consistently because we haven't factored out the immense amount of boilerplate required. There are also some cases where we have POST buttons, which have no fields, and hence for which this pattern does not apply. We also don't have a type safe guarantee that the validation failure branch is dealt with, whereas for example in API payload validation, decorators and Quart level handlers take care of it for us. Ideally we fix this and not only ensure that every existing form implements it, but ensure that it's trivial to support in every new form, just as it is when we add a new API endpoint. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
