sbp commented on PR #302: URL: https://github.com/apache/tooling-trusted-releases/pull/302#issuecomment-3497455618
@jbampton Can't accept this one in the present state for several reasons! The `help` target is at the end instead of in alphabetical order (we could really do with a script to generate the `.PHONY` list for us), there are emoji all over the place, the `help` rule is also at the end instead of alphabetical, and L142 is way longer than our usual 120 column limit. We should probably try to stick to 79 for Makefiles if we can anyway. Also, is `MAKEFILE_LIST` POSIX compatible? Are the grep and awk expressions POSIX compatible? I think sections could just be "# Section name". I appreciate the effort, but this is not a file I would like to have to maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
