sbp commented on code in PR #309: URL: https://github.com/apache/tooling-trusted-releases/pull/309#discussion_r2542157896
########## atr/storage/writers/distributions.py: ########## @@ -23,6 +23,7 @@ import aiohttp import sqlalchemy.exc as exc +from sqlalchemy import text Review Comment: The [PEP8 convention for denoting private interfaces](https://peps.python.org/pep-0008/#public-and-internal-interfaces) is to use a single leading underscore in the interface name. We can use any interface of any dependency which does not begin with a single underscore. We do not rename interfaces when we import them, as our code conventions state. Our standard form is `import a.b as b`, but if importing as `b` causes problems the best alternative is usually `import a.b`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
