sbp commented on issue #361: URL: https://github.com/apache/tooling-trusted-releases/issues/361#issuecomment-3602515059
There are a couple of reasons to continue to think about this in the long term: * Commit 513a1922d18d177c9d6b4dd9e9fdbce9a1a16f9f adds a script to automatically fix function order, if files are formatted in a standard style. We could change the order that it uses if we decide to change the style, and then fixing would be simpler. * Even if we decide not to make changes to ATR style, we may like to use an improved style for other Tooling apps. Another cumbersome thing about the present style, that the new script reminded me of, is that in ASCII `_` sorts before `a-z`, which requires more code to do the sorting. I do it by mapping `_abc` to `abc` and `abc` to `_abc` to obtain the sort keys. We chose to put public functions at the top, however, because they should be more prominent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
