sbp commented on code in PR #430:
URL:
https://github.com/apache/tooling-trusted-releases/pull/430#discussion_r2635613590
##########
atr/sbom/utilities.py:
##########
@@ -164,3 +195,35 @@ def _map_severity(severity: str) -> str:
if sev == "moderate":
return "medium"
return "unknown"
+
+
+def _record_task(task: str, revision: str, doc: yyjson.Document, patch_ops:
models.patch.Patch) -> models.patch.Patch:
+ properties: list[dict[str, str]] | None = get_pointer(doc, "/properties")
Review Comment:
Even tools? Because I don't understand:
```
tools: dict[str, str] | None = get_pointer(doc, "/metadata/tools")
services: list[dict[str, str]] | None = get_pointer(doc,
"/metadata/tools/services")
```
If services are in tools, and tools is `{str: str}` but service values are
themselves `{str: str}`, doesn't this mean that some of the values of tools are
`{str: str}`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
