sbp commented on issue #467: URL: https://github.com/apache/tooling-trusted-releases/issues/467#issuecomment-3708234146
In https://github.com/apache/tooling-trusted-releases/issues/296#issue-3592058162, @potiuk says: > Those .rat-excludes are NOT put at the .root level of those archive files - they are available in the "root folder" (apache-airflow-ctl-0.1.0/) and they apply to this folder recursively. But RAT has no sense of "apply to this folder", as I understand it, so to apply this we have to run RAT _in_ the directory where `.rat-excludes` appears. Meanwhile we also have #428 from @meonkeys, where I said: > We should probably get RAT to report the full path instead. This means that we can't report full paths, unless we modify the output of RAT, which is what I propose we do. I think we should also add a couple of extra rules: 1. Only one `.rat-excludes` file is allowed at most. If there are more than one, that's an error. 2. No files are allowed outside the `.rat-excludes` directory. Otherwise it isn't clear what we should do. Since `.rat-excludes` can only apply to one directory per run of RAT, you can't really have multiple files; you'd have to do multiple runs. And if we're scoping a run to its `.rat-excludes`, then you can't have files outside of that directory because they would bypass the checks. Therefore these two rules appear to be essential. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
