sbp commented on issue #279: URL: https://github.com/apache/tooling-trusted-releases/issues/279#issuecomment-3746418333
@Smitaambiger We still cannot review a PR until we receive both the linting and e2e test outputs, but the issues that you mention here should be very easy to resolve! First you need to [install `biome` by following their instructions](https://biomejs.dev/guides/manual-installation/). It may already be available in your package manager (I installed mine from nixpkgs), and again please let me know if you run into any problems. You also need to run `uv sync --frozen --all-groups`, as that will resolve the errors with `pyright`. Please don't forget that in addition to the lint outputs, we need the output from the e2e tests. We have [instructions for running those tests](https://release-test.apache.org/docs/running-and-creating-tests#running-end-to-end-tests). The lints and the tests are both core parts of the ATR development process. I run lints and tests to get feedback on what I've developed, to help to ensure the quality of my code, and to know that what I wrote at least doesn't break what we added to the tests. But also, it's important to note that your feedback here gives us valuable information about problems that new developers encounter. I will add the notes in this comment to our documentation to make it easier for developers in future to get ATR set up. Therefore you have already contributed to ATR development even without having to write a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
