andrewmusselman opened a new issue, #544:
URL: https://github.com/apache/tooling-trusted-releases/issues/544
## Summary
The application does not set the Strict-Transport-Security header, leaving
users vulnerable to SSL stripping and downgrade attacks.
## ASVS Requirements
- 9.2.1 - HSTS header implementation
## Related Audit Reports
- [Credential Stealing #403](ASVS/credential-stealing-403.md) - Section 3
## Affected Files
- `atr/server.py:213-221`
## Current Behavior
```python
@app.after_request
async def add_security_headers(response):
response.headers["Content-Security-Policy"] = csp_header
response.headers["X-Content-Type-Options"] = "nosniff"
response.headers["X-Frame-Options"] = "DENY"
# Missing: Strict-Transport-Security
return response
```
## Recommended Fix
```python
response.headers["Strict-Transport-Security"] = "max-age=31536000;
includeSubDomains"
```
## Acceptance Criteria
- [ ] HSTS header added with max-age of at least 1 year
- [ ] includeSubDomains directive included
- [ ] Consider preload submission after testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
