sbp commented on code in PR #579:
URL:
https://github.com/apache/tooling-trusted-releases/pull/579#discussion_r2717510499
##########
atr/ssh.py:
##########
@@ -441,10 +506,14 @@ async def _step_07a_process_validated_rsync_read(
if not await aiofiles.os.path.isdir(source_dir):
raise RsyncArgsError(f"Source directory '{source_dir}' not found
for release {release.name}")
- # Update the rsync command path to the determined source directory
- argv[-1] = str(source_dir)
- if not argv[-1].endswith("/"):
- argv[-1] += "/"
+ if file_patterns is None:
+ # Update the rsync command path to the determined source directory
+ argv[-1] = str(source_dir)
+ if not argv[-1].endswith("/"):
+ argv[-1] += "/"
+ else:
+ files = [f for pattern in file_patterns for f in
glob.glob(f"{source_dir}/{pattern}")]
Review Comment:
Oh, I hadn't seen
https://github.com/apache/tooling-trusted-releases/pull/579#issuecomment-3784907378.
We could always put `glob.glob` in `to_thread` if need be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
