sbp commented on PR #595: URL: https://github.com/apache/tooling-trusted-releases/pull/595#issuecomment-3811629514
Thanks for this. I especially appreciate the screenshots of the checks that you ran. There are, however, quite a few problems: * Several instances of `aiohttp.ClientSession` have been missed * The `typestubs` have been reformatted even though they are excluded from reformatting * The unit tests are incorrectly in `tests` rather than `tests/unit` * The `create_secure_session` function is inherently synchronous but is marked as `async` * A lint ignore was added for the above even though the lint warning should have been heeded * Function order is not alphabetical, as per our style guide Since the PR is, however, functional, I will accept it and fix these problems in a subsequent commit. By the way, the `make check` errors that you are receiving are because you need to sync all groups in `uv` using `uv sync --frozen --all-groups`. Thanks again for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
