erisu commented on issue #4: URL: https://github.com/apache/tooling-actions/issues/4#issuecomment-3811753086
> packages should not be in the main directory of their repository. The packages were not in the main directory of the repository. I created and committed an empty release-staging directory within the repo and added a `.gitkeep` file so I could commit an empty directory. If a directory didn't exist before executing `npm pack` for the convenience package or `git archive` for the source packages, the command would have failed (`for writing: No such file or directory`). Maybe I was overthinking the structure. I wrote it this way specifically so both reviewers and I could test each GHA workflow step locally and reproduce each tarball and checksum to compare with what was published to the ATR. The directory was also added to `.gitignore` so `git status`/`git diff` wouldn't complain about new untracked files. I was probably trying to avoid a setup step (`mkdir`) in actions so that the release and review documentation remained as simple as executing `git archive`, `npm pack`, and `sha512sum`. There might be an optional solution I could implement on my end. For example, I could delete the `.gitkeep`, in a step on GHA workflow, file before running `upload-to-atr` step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
