sbp commented on code in PR #608:
URL:
https://github.com/apache/tooling-trusted-releases/pull/608#discussion_r2744120709
##########
atr/mail.py:
##########
@@ -47,40 +50,46 @@ class Message:
in_reply_to: str | None = None
-async def send(message: Message) -> tuple[str, list[str]]:
+async def send(msg_data: Message) -> tuple[str, list[str]]:
Review Comment:
Yes, because an import was added (`import email.message as message`)
following our style guide to import the smallest component's name, which then
causes `message` in this argument specification to be shadowing. We want to
avoid shadowing, so this argument needed renaming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]