andrewmusselman opened a new issue, #659:
URL: https://github.com/apache/tooling-trusted-releases/issues/659

   **Audit refs:** 8.1.1 CRITICAL-03, 8.2.1 ยง2.4
   
   #### Description
   
   When `ALLOW_TESTS` is enabled:
   
   1. **All** authenticated users (not just the test user) are granted 
membership in the "test" committee and project (`atr/principal.py:312-319`).
   2. Authorization checks in the storage layer are **completely skipped** for 
the test committee (`atr/storage/writers/release.py:185-191`).
   3. Rate limiting is disabled (`atr/server.py`).
   4. A hardcoded "test" user bypasses LDAP verification.
   
   If `ALLOW_TESTS` is accidentally left enabled in production, every 
authenticated user gains unauthorized access.
   
   #### Recommended fix
   
   1. Document that this flag requires DEBUG_MODE to be set
   2. Ensure `atr/docs` is read during audits
   
   **CWE:** CWE-863 (Incorrect Authorization) | **CVSS:** 8.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to