andrewmusselman commented on issue #660: URL: https://github.com/apache/tooling-trusted-releases/issues/660#issuecomment-3912472245
Related, same fix: # Token deletion missing ownership validation **Audit refs:** 8.1.1 MEDIUM-06, 8.3.1 HIGH-05, 8.2.2 HIGH-002 #### Description Token and key deletion operations lack ownership verification: 1. `atr/post/tokens.py:60-65` — `_delete_token()` passes `token_id` from form data to deletion without verifying the authenticated user owns the token. 2. `atr/api/__init__.py:343-358` — `/key/delete` API authenticates via JWT but does not verify key ownership before deletion. #### Recommended fix Add ownership verification: ```python await wafc.tokens.delete_token(delete_form.token_id, owner_uid=session.uid) ``` **CWE:** CWE-639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
