andrewmusselman opened a new issue, #699:
URL: https://github.com/apache/tooling-trusted-releases/issues/699
**ASVS:** 15.3.1 · Finding 1
**Severity:** HIGH
**CWE:** CWE-200 (Exposure of Sensitive Information)
### Description
The `/admin/configuration` endpoint in `atr/admin/__init__.py` (lines
232–248) only redacts configuration values whose names end in `_PASSWORD`. This
leaves multiple sensitive secrets exposed in the admin UI:
- `JWT_SECRET_KEY` — enables token forgery
- `GITHUB_TOKEN` — unauthorized GitHub API access
- `SVN_TOKEN` — unauthorized SVN operations
- `LOG_PUBLIC_KEY`, `PUBSUB_URL`, `PUBSUB_USER`
```python
if name.endswith("_PASSWORD"): # Only redacts _PASSWORD suffix
val = log.python_repr("redacted")
```
### Recommendation
Broaden the redaction to match common sensitive configuration patterns:
```python
SENSITIVE_CONFIG_PATTERNS = ("_PASSWORD", "_KEY", "_TOKEN", "_SECRET",
"PUBSUB_URL", "PUBSUB_USER")
if any(pattern in name for pattern in SENSITIVE_CONFIG_PATTERNS):
val = log.python_repr("redacted")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
