andrewmusselman opened a new issue, #761:
URL: https://github.com/apache/tooling-trusted-releases/issues/761
**ASVS:** 1.2.2 | **CWE:** CWE-601, CWE-79 | **Severity:** HIGH |
**Effort:** Low
### Description
In `src/asfquart/generics.py` (lines ~26–54), the `login` query parameter
from the OAuth endpoint is stored and later used in a `Refresh` header without
protocol or host validation:
```python
login_uri = quart.request.args.get("login") # User-controlled
# ...later...
headers={"Refresh": f"0; url={redirect_uri}"} # Unvalidated URI
```
This enables open redirects and potential XSS via `javascript:` or `data:`
URLs after OAuth login completes.
### Remediation
Validate that the `login` parameter is a relative URL (no scheme, no netloc)
or restrict to same-origin before storing and using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
