dave2wave commented on code in PR #803:
URL:
https://github.com/apache/tooling-trusted-releases/pull/803#discussion_r2873428599
##########
atr/get/upload.py:
##########
@@ -152,6 +153,56 @@ async def selected(
_render_ssh_keys_info(block, user_ssh_keys)
+ block.h2(id="github-upload")["GitHub Workflow"]
+ block.p["Upload files into this draft from a GitHub repository using
GitHub Actions."]
Review Comment:
Insert the phrase "If your project is approved for reproducible builds, "
before "Upload"
##########
atr/get/upload.py:
##########
@@ -152,6 +153,56 @@ async def selected(
_render_ssh_keys_info(block, user_ssh_keys)
+ block.h2(id="github-upload")["GitHub Workflow"]
+ block.p["Upload files into this draft from a GitHub repository using
GitHub Actions."]
+ block.append(
+ htm.ol[
+ htm.li["Ensure GitHub Actions is enabled for your repository"],
+ htm.li[
+ "Create a new workflow file in the .github/workflows/
directory of your repository, ",
+ "following the steps ",
+
htm.a(href="https://docs.github.com/en/actions/tutorials/create-an-example-workflow";)["here"],
+ ],
+ htm.li["Add the example code below to your workflow file, making
sure to set the correct file paths"],
+ ]
+ )
+ block.pre[
+ f"""
+name: Upload to ATR
+on:
+ workflow_dispatch:
+
+jobs:
+ upload:
+ permissions:
+ id-token: write
+ contents: read
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
+
+ - name: Build artifacts
+ run: |
+ ./build.sh
+
+ - name: Upload to ATR
+ uses:
apache/tooling-actions/upload-to-atr@04741906f3f38a64ed4489bb12ad78b99424a7a0
+ with:
+ project: {project_name!s}
+ version: ${{{{ github.ref_name }}}}
+ """
+ ]
+ block.p[
Review Comment:
The following `htm.code` blocks would look better if the blanks were like
so: `htm.code[" github.ref_name "]`
##########
atr/htm.py:
##########
@@ -61,6 +61,7 @@
title = htpy.title
tr = htpy.tr
ul = htpy.ul
+ol = htpy.ol
Review Comment:
The css margins for the `ol` and included `li` need adjustment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
