sbp commented on code in PR #809:
URL:
https://github.com/apache/tooling-trusted-releases/pull/809#discussion_r2878471939
##########
atr/post/tokens.py:
##########
@@ -42,7 +42,9 @@ async def jwt_post(session: web.Committer, _tokens_jwt:
Literal["tokens/jwt"], _
URL: /tokens/jwt
"""
jwt_token = jwtoken.issue(session.uid)
- return web.TextResponse(jwt_token)
+ response = web.TextResponse(jwt_token)
+ response.headers["Cache-Control"] = "no-store, no-cache"
Review Comment:
These are [mutually
exclusive](https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Cache-Control#no-cache):
> Note that no-cache does not mean "don't cache". no-cache allows caches to
store a response but requires them to revalidate it before reuse. If the sense
of "don't cache" that you want is actually "don't store", then `no-store` is
the directive to use.
This route returns a fresh response on every request, so I think that
`no-store` is appropriate.
##########
atr/web.py:
##########
@@ -271,6 +271,7 @@ def __call__(self, *args: Any, **kwargs: Any) ->
Awaitable[R]: ...
class ShellResponse(quart.Response):
+ # audit_guidance this is an intentional use of x-shellscript without
Content-Disposition
Review Comment:
I'd prefer `Audit guidance:`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
