sbp commented on issue #841: URL: https://github.com/apache/tooling-trusted-releases/issues/841#issuecomment-4047327660
This specific bug was caused by using the `atr.models.sql.ReleasePolicy` Pydantic model to read historical attestable data after it had been migrated. The database has Alembic migrations applied to it, but because attestable data is immutable for audit purposes we cannot apply migrations. We could either create an analogue of every `atr.models.sql.ReleasePolicy` and version them, or make the parser much more forgiving. If we choose the latter then we would need to have a codebase policy that we never change the meaning of a policy property. In this case, the incorrect values were anyway just caused by another bug: when we added the migration, it migrated existing release policies to have `None` values for the new fields, because we didn't declare `nullable=False` in the migration, contrary to the SQL model. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
