dave2wave commented on code in PR #1005:
URL:
https://github.com/apache/tooling-trusted-releases/pull/1005#discussion_r3017216677
##########
atr/ldap.py:
##########
@@ -249,6 +249,8 @@ async def is_active(asf_uid: str) -> bool:
return True
if config.get().ALLOW_TESTS and (asf_uid == "test"):
return True
+ if config.get().ALLOW_TESTS and (asf_uid == "test-banned"):
+ return False
Review Comment:
Would this be better as:
```
if config.get().ALLOW_TESTS:
if asfuid == "test":
return True
if asfuid == "test-banned":
return False
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
