asf-tooling opened a new issue, #1116: URL: https://github.com/apache/tooling-trusted-releases/issues/1116
**ASVS Level(s):** L1 **Description:** ### Summary API models accept plain string for phase parameter (compose/vote/finish/published) rather than using Literal type enum, allowing invalid phase values that should be rejected at validation layer. ### Details In `atr/models/api.py`, the phase parameter is defined as plain `str` rather than using `Literal['compose', 'vote', 'finish', 'published']` to enforce valid values at the validation layer. ### Recommended Remediation Replace `phase: str` with `phase: Literal['compose', 'vote', 'finish', 'published']` in API models to enforce valid phase values at validation layer. ### Acceptance Criteria - [ ] Phase parameter uses Literal type enum - [ ] Invalid phase values rejected at validation layer - [ ] Clear error messages for invalid phases - [ ] Unit tests verify validation ### References - Source reports: L1:8.3.1.md - Related findings: FINDING-150 - ASVS sections: 8.3.1 ### Priority Low --- --- **Triage notes:** check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
