alitheg commented on code in PR #1186:
URL:
https://github.com/apache/tooling-trusted-releases/pull/1186#discussion_r3125063989
##########
atr/util.py:
##########
@@ -382,6 +360,16 @@ def email_from_uid(uid: str) -> str | None:
return None
+def ensure_project_active(project: sql.Project) -> None:
Review Comment:
Ah, yes - I looked at putting it in the root but the only things in the root
currently were classes for the actual readers and writers and the methods you
call to access them. If you're happy with essentially a utility class living in
there too it's an easy move!
##########
playwright/test.py:
##########
@@ -573,6 +579,46 @@ def test_all(page: Page, credentials: Credentials,
skip_slow: bool) -> None:
logging.info(f"Tests took {round(finish - start, 3)} seconds")
+def test_archive_01_banner_absent_when_active(page: Page, credentials:
Credentials) -> None:
Review Comment:
Ah I thought we were trying to only use Playwright for new tests and e2e was
old. Or have I got that entirely the wrong way around (or totally wrong)?
##########
tests/e2e/tokens/helpers.py:
##########
@@ -26,7 +26,7 @@
def delete_token_by_label(page: Page, label: str) -> None:
row = get_token_row_by_label(page, label)
if row.count() > 0:
- row.get_by_role("button", name="Delete").click()
Review Comment:
I thought Revoke was more correct for tokens, since unlike SSH keys (which
are always *valid* it's just the user chooses where they're accepted), we issue
them. I can leave at delete if you prefer.
##########
tests/e2e/tokens/helpers.py:
##########
@@ -26,7 +26,7 @@
def delete_token_by_label(page: Page, label: str) -> None:
row = get_token_row_by_label(page, label)
if row.count() > 0:
- row.get_by_role("button", name="Delete").click()
Review Comment:
I made it in the SSH key changes set but because the e2e tests aren't run in
CI (see my above comment/question about which tests are *current*), I missed
that the tests were failing.
##########
tests/e2e/tokens/helpers.py:
##########
@@ -26,7 +26,7 @@
def delete_token_by_label(page: Page, label: str) -> None:
row = get_token_row_by_label(page, label)
if row.count() > 0:
- row.get_by_role("button", name="Delete").click()
Review Comment:
I made it in the SSH key changes set but because the e2e tests aren't run in
CI (see my above comment/question about which tests are *current*), I missed
that the tests were failing. Usually I run them all but clearly missed this
time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
