andrewmusselman commented on PR #1207:
URL:
https://github.com/apache/tooling-trusted-releases/pull/1207#issuecomment-4356925016
> * Type ignores shouldn't be necessary in tests, as tests are ignored.
>
> * Top level comments break the function order script. Try running `git
diff --cached --name-only -- '*.py' | xargs -I {} sh scripts/fix_order.sh {}`
on staged changes.
Good notes — all three addressed. Docstrings collapsed to one line per
symbol. The two # type: ignore[no-untyped-def] comments in
tests/unit/test_api_auth_decorators.py are gone. The four explanatory top-level
comments I'd added (in api.py above __all__ and _route_auth_levels, in
api_auth.py above AUTH_LEVEL_ATTR) are removed; _route_auth_levels moved up
next to the other _BLUEPRINT* module state so fix_order.py is happy. Verified
clean with python3 scripts/fix_order.py on every touched file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
