asf-tooling commented on issue #1202:
URL:
https://github.com/apache/tooling-trusted-releases/issues/1202#issuecomment-4409690146
<!-- gofannon-issue-triage-bot v2 -->
**Automated triage** — analyzed at `main@2da7807a`
**Type:** `refactor` • **Classification:** `actionable` •
**Confidence:** `low`
**Application domain(s):** `release_lifecycle`, `shared_infrastructure`
### Summary
Issue #1202 requests changing the navigation element on release phase pages
(compose, vote, finish, announce) to use the same '1 -> 2 -> 3' stepped format
with phase labels and per-phase colors that already exists on the release
overview page. This is a UI consistency improvement suggested by @epugh during
testing. I cannot cite specific template code because the template files were
not included in the source files provided to me, though the architecture
clearly indicates templates exist under shared infrastructure and
phase-specific route handlers.
### Where new code would go
- `atr/get/compose.py` — template rendering for compose phase
This route handler renders the compose phase page that would need the
updated navigation element
- `atr/get/vote.py` — template rendering for vote phase
This route handler renders the vote phase page that would need the updated
navigation element
- `atr/get/finish.py` — template rendering for finish phase
This route handler renders the finish phase page that would need the
updated navigation element
- `templates/` — new file or modification to existing partial/include
The navigation component likely lives in a shared template partial that is
included in phase page templates. A shared 'phase_nav' component would be
created or the existing release overview navigation component would be
extracted and reused.
### Proposed approach
The existing release overview page already has a navigation element showing
phases as '1 -> 2 -> 3' with labels and per-phase colors. The implementation
should extract that navigation component into a shared Jinja2 partial/macro (if
not already shared) and include it in each phase page template (compose, vote,
finish, announce). The component should accept the current phase as a parameter
to highlight/style the active phase appropriately.
Without access to the template source files, I cannot provide concrete
diffs. The implementer should: (1) identify the navigation HTML/CSS in the
release overview template, (2) extract it into a reusable partial (e.g.,
`_phase_nav.html`), (3) include that partial in each phase page template with
the appropriate current-phase context variable, and (4) remove or replace
whatever navigation element currently exists on phase pages.
### Open questions
- What template engine/structure is used? (likely Jinja2 templates in a
templates/ directory, but the exact path and naming convention is not visible)
- Is the release overview navigation already implemented as a reusable
partial, or is it inline in the overview template?
- What is the current navigation element on phase pages that needs to be
replaced?
- Are there CSS/static asset changes needed, or is it purely template markup?
- Which file contains the release overview page template with the existing
'1 -> 2 -> 3' navigation?
### Files examined
- `tests/e2e/announce/conftest.py`
- `tests/e2e/vote/conftest.py`
- `tests/e2e/voting/conftest.py`
- `.asf.yaml`
- `.github/PULL_REQUEST_TEMPLATE.md`
- `.github/dependabot.yml`
- `.github/labeler.yml`
- `.github/linters/.markdown-lint.yml`
### Related issues
This issue appears related to: #1187.
_Both address UI consistency improvements across phase pages and result
tables_
---
*Draft from a triage agent. A human reviewer should validate before merging
any change. The agent did not run tests or verify diffs apply.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
