asf-tooling commented on issue #524:
URL:
https://github.com/apache/tooling-trusted-releases/issues/524#issuecomment-4410178009
<!-- gofannon-issue-triage-bot v2 -->
**Automated triage** — analyzed at `main@2da7807a`
**Type:** `documentation` • **Classification:** `no_action` •
**Confidence:** `high`
**Application domain(s):** `authentication_authorization`,
`project_committee_management`
### Summary
This issue requests documentation changes on the external Apache
Infrastructure site (infra.apache.org/release-publishing.html#releasemanager)
to describe the two definitions of the 'Release Manager' role in ATR. The prior
discussion is solely about assigning the issue to Andrew Wetmore (@cottage14).
The ATR codebase already has the `release_managers` concept implemented
(visible in `sql.Committee.release_managers` referenced in
`atr/get/projects.py`), so this issue tracks the accompanying infrastructure
documentation work, not a code change to this repository.
### Where this lives in the code today
#### `atr/user.py` — `is_committee_member` (lines 97-100)
_currently does this_
Shows the existing PMC member check; the Release Manager role described in
the issue is a separate concept from being a committee member.
```python
def is_committee_member(committee: sql.Committee | None, uid: str) -> bool:
if committee is None:
return False
return any((member_uid == uid) for member_uid in
committee.committee_members)
```
#### `atr/user.py` — `is_committer` (lines 103-106)
_currently does this_
Shows committer check; the issue describes how committers (not just PMC
members) can serve as Release Managers in the classic model.
```python
def is_committer(committee: sql.Committee | None, uid: str) -> bool:
if committee is None:
return False
return any((committer_uid == uid) for committer_uid in
committee.committers)
```
### Proposed approach
This issue is about updating documentation on the external site
infra.apache.org, not about changing code in this repository. The ATR codebase
already has the `release_managers` concept implemented (the `sql.Committee`
model has a `release_managers` attribute used in project selection logic). The
documentation that needs updating lives in the apache/infrastructure-website
repository (or equivalent), specifically at
https://infra.apache.org/release-publishing.html#releasemanager.
No code changes are needed in this repository. The issue was filed here to
track the need for infra documentation to be updated to reflect ATR's Release
Manager model. @dave2wave attempted to assign it to Andrew Wetmore (@cottage14)
for the documentation work.
### Open questions
- Is the documentation work tracked elsewhere (e.g., in the
apache/infrastructure-website repo)?
- Has @cottage14 started work on the infra documentation updates?
- Should this issue be transferred to the infrastructure-website repository
since the actual changes are there?
_The agent reviewed this issue and is not proposing patches in this run.
Review the existing-code citations and open questions above before deciding
next steps._
### Files examined
- `atr/user.py`
- `atr/principal.py`
- `atr/storage/writers/project.py`
- `atr/get/projects.py`
- `atr/post/projects.py`
- `atr/get/committees.py`
- `atr/shared/projects.py`
### Related issues
This issue appears related to: #526.
_Both address documentation updates needed on infra.apache.org for ATR
integration_
---
*Draft from a triage agent. A human reviewer should validate before merging
any change. The agent did not run tests or verify diffs apply.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
