alitheg commented on code in PR #1248:
URL: 
https://github.com/apache/tooling-trusted-releases/pull/1248#discussion_r3264686453


##########
atr/post/announce.py:
##########
@@ -146,6 +121,14 @@ async def selected(
                 email_cc=announce_form.email_cc,
                 email_bcc=announce_form.email_bcc,
             )
+            if archive_prior is not None:
+                archive_error = await wacm.release.archive(project_key, 
archive_prior.safe_version_key)

Review Comment:
   With the other plumbing to be added (SVN etc) I wonder if in this case it's 
worth leaving it here - especially since if that operation fails the user 
should be able to go and archive the release themselves.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to