alitheg commented on code in PR #1264:
URL:
https://github.com/apache/tooling-trusted-releases/pull/1264#discussion_r3287134618
##########
atr/storage/writers/distributions.py:
##########
@@ -302,6 +309,12 @@ async def __upgrade_staging_to_final(
version=version,
).demand(RuntimeError(f"Distribution {tag} not found"))
if existing.staging:
+ # TODO(#751): When remote promotion of artifacts to third party
+ # platforms is implemented, assert here that
existing.staging_revision_key
+ # equals the current Revision.key for the release before flipping
+ # staging to False, so that the artifacts being promoted are
+ # guaranteed to match those that were voted on. The column was
+ # added in #751 for exactly this purpose.
Review Comment:
Otherwise, I don't see any obvious problems here, but I'll wait for @sbp too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
