Do the makefile commands still function? It's been awhile for me and I just tried `make dev` assuming that it would attempt to build the jars first and then copy them into a docker container per the Dockerfile definition. Instead, it fails due to missing dist/toree. It also looks like the Dockerfile is using the outdated ADD command instead of COPY that is the better practice in 99% of cases. I know when we wrote this years ago the Dockerfile was defined before COPY was available in Docker, so we should probably open a ticket to spruce up the Dockerfile.
We also have outdated documentation for the release process if I'm reading it correctly. We have a disclaimer that `make release` uses Docker, which implies that the build of Toree happens inside a container. From what I can see, there doesn't appear to be any Docker usage in the release process. I tried to install sbt from scratch on my local machine and build, but am having difficulties due to x86 requirements of sbt and my ARM device. Will try again later to verify! On Mon, Sep 13, 2021 at 4:35 PM Kevin Bates <[email protected]> wrote: > > Thanks for managing all of this Luciano. I've taken 0.5.0 for a spin. > > [x] +1 Release this package as Apache Toree 0.5.0-incubating > > On Sun, Sep 12, 2021 at 11:15 PM Luciano Resende <[email protected]> > wrote: > > > +1 from myself, could I get some other community members to review? > > > > On Mon, Sep 6, 2021 at 9:11 PM Luciano Resende <[email protected]> > > wrote: > > > > > Please vote to approve the release of Apache Toree 0.5.0-incubating > > (RC4). > > > > > > The changes in this release are mainly to add support for Spark 3.0.0. > > > > > > > > > > > https://github.com/apache/incubator-toree/compare/v0.4.0-incubating-rc1...v0.5.0-incubating-rc4 > > > > > > Also, note that for this release, due to changes on the Incubator release > > > policy, we are > > > producing two pip packages, one as apache-toree and another as toree for > > > backward > > > compatibility purposes. > > > > > > Tag: v0.5.0-incubating-rc4 (2fcff105844e3ff80b8dda3284182d862fbaa489) > > > > > > https://github.com/apache/incubator-toree/tree/v0.5.0-incubating-rc4 > > > > > > All distribution packages, including signatures, digests, etc. can be > > > found at: > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/toree/0.5.0-incubating-rc4/ > > > > > > Staging artifacts can be found at: > > > > > > https://repository.apache.org/content/repositories/orgapachetoree-1019 > > > > > > ## Testing Instructions > > > > > > The fastest way to get up and running is to using Jupyter. > > > > > > 1. Install Jupyter if you haven't already ( > > http://jupyter.org/install.html > > > ) > > > > > > 2. Install Apache Toree via `pip install > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/toree/0.5.0-incubating-rc4/toree-pip/toree-0.5.0.tar.gz` > > <https://dist.apache.org/repos/dist/dev/incubator/toree/0.5.0-incubating-rc4/toree-pip/toree-0.5.0.tar.gz> > > > < > > https://dist.apache.org/repos/dist/dev/incubator/toree/0.5.0-incubating-rc4/toree-pip/toree-0.5.0.tar.gz > > > > > > followed by `jupyter toree install` > > > > > > - You need to set a valid Apache Spark 3.x home, which can be done via > > > `jupyter toree install --spark_home=/usr/local/spark` > > > > > > - You may need to run with `sudo` for installation permission > > > > > > - For all installation options, run `jupyter toree install --help-all` > > > > > > 4. Run a Jupyter notebook server via `jupyter notebook` > > > > > > - If the notebook portion of Jupyter is not installed but Jupyter is, > > > you can install via `pip install notebook` > > > > > > 5. Create a notebook using "Apache Toree - Scala" from the dropdown under > > > new > > > dev > > > 6. Run Scala/Spark commands such as `sc.parallelize(1 to 100).sum()` in > > the > > > notebook > > > > > > ## Voting Instructions > > > > > > The vote is open for at least 72 hours and passes if a majority of at > > least > > > 3 +1 PMC votes are cast. > > > > > > [ ] +1 Release this package as Apache Toree 0.5.0-incubating > > > [ ] -1 Do not release this package because ... > > > > > > -- > > > Luciano Resende > > > http://twitter.com/lresende1975 > > > http://lresende.blogspot.com/ > > > > > > > > > -- > > Luciano Resende > > http://twitter.com/lresende1975 > > http://lresende.blogspot.com/ > >
