New release candidate out on https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
On Fri, Oct 7, 2016 at 12:19 PM Gino Bustelo <g...@bustelos.com> wrote: > Awesome... we will work on those. Thanks for the feedback! > > On Thu, Oct 6, 2016 at 8:11 PM Luciano Resende <luckbr1...@gmail.com> > wrote: > > Great, I spend a little time reviewing the current packages and below are > my comments > > - Artifacts and extracted folders are probably best if called > apache-toree-xxxx > - BSD licenses require notice ( > http://software.clapper.org/grizzled-scala/license.html) and should go > under notice or copied into the LICENSE file > - Source package has derby.log > - Source package has binary jars : ./etc/tools/apache-rat-0.11.jar > ./kernel/lib/mesos-0.18.1-shaded-protobuf.jar > - And I believe these other jars are for test purposes, which then might be > ok > ./scala-interpreter/src/test/resources/ScalaTestJar.jar > ./scala-interpreter/src/test/resources/TestJar.jar > ./scala-interpreter/src/test/resources/TestJar2.jar > > ./sparkr-interpreter/src/main/resources/R/pkg/inst/test_support/sparktestjar_2.10-1.0.jar > > - rat is giving the following unapproved licenses > > Unapproved licenses: > > ./.example-image > ./.jvmopts > ./README.md > ./RELEASE_NOTES.md > ./derby.log > ./index.ipynb > ./client/src/main/resources/client-ivy.xml > ./client/src/main/resources/toree-client-ivy.xml > ./client/src/test/resources/kernel-profiles/IOPubIntegrationProfile.json > ./communication/src/main/resources/toree-communication-ivy.xml > ./etc/.src-release-ignore > ./etc/kernel.json > ./etc/pip_install/MANIFEST.in > ./kernel/src/main/resources/toree-kernel-ivy.xml > ./kernel/src/test/resources/fixtures/profile.json > ./kernel-api/src/main/resources/toree-kernel-api-ivy.xml > ./macros/src/main/resources/toree-macros-ivy.xml > ./plugins/src/main/resources/toree-plugins-ivy.xml > ./protocol/src/main/resources/toree-protocol-ivy.xml > > ./pyspark-interpreter/src/main/resources/toree-pyspark-interpreter-ivy.xml > ./scala-interpreter/src/main/resources/toree-scala-interpreter-ivy.xml > ./sparkr-interpreter/src/main/resources/README.md > ./sparkr-interpreter/src/main/resources/package-sparkR.sh > ./sparkr-interpreter/src/main/resources/toree-sparkr-interpreter-ivy.xml > ./sparkr-interpreter/src/main/resources/R/.gitignore > ./sparkr-interpreter/src/main/resources/R/DOCUMENTATION.md > ./sparkr-interpreter/src/main/resources/R/README.md > ./sparkr-interpreter/src/main/resources/R/WINDOWS.md > ./sparkr-interpreter/src/main/resources/R/pkg/.lintr > ./sparkr-interpreter/src/main/resources/R/pkg/DESCRIPTION > ./sparkr-interpreter/src/main/resources/R/pkg/NAMESPACE > ./sql-interpreter/src/main/resources/toree-sql-interpreter-ivy.xml > ./src/main/resources/root-ivy.xml > ./src/main/resources/toree-ivy.xml > > - Please do a grep -ri SNAPSHOT * which is showing a bunch of SPANSHOT > dependencies... this seems wrong > > > On Thu, Oct 6, 2016 at 2:50 PM, Gino Bustelo <g...@bustelos.com> wrote: > > > branch delete and artifacts are now at > > https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc1/ > > > > On Thu, Oct 6, 2016 at 3:30 PM Gino Bustelo <g...@bustelos.com> wrote: > > > > > May have figured out my problem... being an incubator... need to go > under > > > `\dist\incubator\toree`. Lets see. Wish me luck! > > > > > > On Thu, Oct 6, 2016 at 3:18 PM Gino Bustelo <g...@bustelos.com> wrote: > > > > > > I'm trying to commit to https://dist.apache.org/repos/dist and get the > > > error below. Does this mean that my account does not have access to > svn. > > > > > > ``` > > > > > > Adding toree > > > > > > svn: E195023: Commit failed (details follow): > > > > > > svn: E195023: Changing directory > > > '/Users/ginobustelo/Dev/spark/apache-dist-dev/toree' is forbidden by > the > > > server > > > > > > svn: E175013: Access to '/repos/dist/!svn/txr/16406-dyo/dev/toree' > > > forbidden > > > > > > ``` > > > > > > On Thu, Oct 6, 2016 at 9:34 AM Gino Bustelo <g...@bustelos.com> wrote: > > > > > > So our intention was to put things somewhere for our mentors to help > out > > > vetting what we will eventually put out for the vote. According to > Hitesh > > > in this thread... "only one single source release which is going to be > > > voted upon". > > > > > > It is confusing where things need to go. I can't find documentation > that > > > says that we need to upload to a specific place for voting. It may be > > > documented, but seriously... this process if full of confusion and > poorly > > > documented (maybe overly documented) and it seems that not all projects > > do > > > the same thing. > > > > > > We need the following from our Mentors as it regards to "*GETTING READY > > > FOR THE VOTE*" > > > > > > 1. We followed the checklist here ( > > > > http://incubator.apache.org/guides/releasemanagement.html#check-list) > > > and wanted to get a verification that we've done this right. You > > should be > > > able to verify this using the link above. > > > 2. Clear instructions of where we put all our candidate assets (FOR > > > THE VOTE) > > > 1. source package > > > 2. simple binary package > > > 3. pip release (we want to push this to pypi once accepted) > > > 4. maven artifacts > > > > > > Thanks, > > > Gino > > > > > > On Wed, Oct 5, 2016 at 4:42 PM Luciano Resende <luckbr1...@gmail.com> > > > wrote: > > > > > > This is not following the release guidelines. Did you check the release > > > script I sent [1] ? Also, I know you guys are subscribed to > general@a.o > > , > > > it's good to check how some other podlings are handling releases just > to > > > have a feeling of things to watch for. > > > > > > > > > - Don't pollute your official source repository with these artifacts, > git > > > is for source code, the release candidate should be stored at > > > https://dist.apache.org/repos/dist/dev/ inside a toree/rc folder. Once > > > approved, it then gets moved to > > > https://dist.apache.org/repos/dist/release/ > > > inside a toree folder/r. See other projects how they work. > > > > > > - Maven artifacts if any should go into a staging repository at > > > repository.apache.org > > > > > > - If distributing scala binary artifacts, you might want to publish > > > artifacts for all supported scala versions _2.10 and _2.11 > > > > > > Other then these, a minor thing is that I would call the folder where > the > > > archive gets installed as apache-toree instead of toree only. > > > > > > [1] https://github.com/apache/bahir/blob/master/dev/release-build.sh > > > > > > > > > On Wed, Oct 5, 2016 at 2:03 PM, Gino Bustelo <g...@bustelos.com> > wrote: > > > > > > > We did a build and placed the source and bin package here ( > > > > https://github.com/apache/incubator-toree/tree/ > > > > 70c2b7d55ed3f42400844c2c5c311a70d5afbefe). > > > > If this is fine, we can then go and call for a vote. > > > > > > > > On Wed, Oct 5, 2016 at 12:34 PM Hitesh Shah <hit...@apache.org> > wrote: > > > > > > > > > Additionally to clarify, there is only one single source release > > which > > > is > > > > > going to be voted upon. You can provide multiple binary artifacts > for > > > > > convenience along with the main source release ( these will be > looked > > > at > > > > > for correctness of the contents but not voted upon). The binary > bits > > > > could > > > > > be different to match which version of spark they were built > against. > > > All > > > > > of these artifacts (source tarball, binary tarball for spark 1.6, > > > binary > > > > > tarball for spark2 ) will need their own different license and > notice > > > > files. > > > > > > > > > > — Hitesh > > > > > > > > > > > > > > > > On Oct 5, 2016, at 1:10 AM, Luciano Resende < > luckbr1...@gmail.com> > > > > > wrote: > > > > > > > > > > > > On Tue, Oct 4, 2016 at 11:18 PM, Chip Senkbeil < > > > > chip.senkb...@gmail.com> > > > > > > wrote: > > > > > > > > > > > >> Sure. > > > > > >> > > > > > >> On Wed, Oct 5, 2016 at 12:46 AM Luciano Resende < > > > luckbr1...@gmail.com > > > > > > > > > > >> wrote: > > > > > >> > > > > > >>> Can we move this discussion to public ? > > > > > >>> > > > > > >>> On Tue, Oct 4, 2016 at 10:27 PM, Chip Senkbeil < > > > > > chip.senkb...@gmail.com> > > > > > >>> wrote: > > > > > >>> > > > > > >>> Was starting to read through this link: > > > > > >>> http://incubator.apache.org/guides/releasemanagement.html# > > > > > >> best-practice-incubator-release-vote > > > > > >>> > > > > > >>> A lot of the content has "TODO: Blah blah link" in place of > > actual > > > > > links > > > > > >>> to content, so was hoping to get a rough outline from a mentor, > > if > > > > > >>> possible. Since we're wanting to release for two different > > versions > > > > of > > > > > >>> Toree (one supporting Spark 1.x and the other for 2.x), I'm > > > assuming > > > > we > > > > > >>> need two separate vote threads with artifacts for each, right? > > > > > >>> > > > > > >>> > > > > > >>> > > > > > >>> > > > > > >> > > > > > > > > > > > > First, the most important thing for the first release will make > > sure > > > > that > > > > > > we try to clear all the legal files, so things like running RAT > and > > > > also > > > > > > double checking the license/notice, signatures, etc will take > most > > of > > > > the > > > > > > time. After that, we could borrow scripts from different projects > > to > > > > > > actually do the release, see this from Bahir as an example : > > > > > > https://github.com/apache/bahir/blob/master/dev/release-build.sh > . > > As > > > > for > > > > > > voting, as long it's all one "release", even tough it might be > > > multiple > > > > > > packages/artifacts, you can combine the votes as one... > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Luciano Resende > > > > > > http://twitter.com/lresende1975 > > > > > > http://lresende.blogspot.com/ > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Luciano Resende > > > http://twitter.com/lresende1975 > > > http://lresende.blogspot.com/ > > > > > > > > > > > > -- > Luciano Resende > http://twitter.com/lresende1975 > http://lresende.blogspot.com/ > >
