KEYS file should be at the top of the source tree and also inside the https://dist.apache.org/repos/dist/release/incubator/toree/ dir. markdown files support comments so ideally the apache license header should be added. When in doubt, keep the NOTICE file as small as possible. I would probably err on the side of keeping it out of the NOTICE file for now and retain the copyright line in the LICENSE file. I would recommending adding a couple of lines in the incubator vote for folks to review the license/notice files carefully as this is the first release. For the one license per type - not a stop-ship but something to look at in the future based on comments from the IPMC vote. test-jars: Any reason they cannot be downloaded as part of the tests and cached? In any case, as long as there is an ALv2 lineage for them, this is not a stop-ship for now.
thanks — Hitesh > On Oct 17, 2016, at 8:41 AM, Gino Bustelo <g...@bustelos.com> wrote: > > I'm working on changes in https://github.com/apache/incubator-toree/pull/75. > I've address most of the issues above. > >> - no KEYS file so no way to verify the gpg signature ( unless one > downloads an unverified key from a public server ) > Where do I put this KEYS file? > >> - Something to check on - are the copyrights needed in the NOTICE file or > the LICENSE file? I am not too sure if there are needed in the NOTICE file. > Who can answer this? Is this a stop ship problem? > >> - Most projects tend to have one license file per license type and not a > license file per dependency - with the copyrights called out in the main > LICENSE file I believe. > We did the initial work to prep for release a while back, so I can't > remember what project we modeled against. Is this a stop ship problem? > >> - bunch of markdown files without a license header > Do we have to add headers to these? Look at markdown files in Spark ( > https://raw.githubusercontent.com/apache/spark/cff560755244dd4ccb998e0c56e81d2620cd4cff/docs/quick-start.md), > they have no headers. > >> - there are a bunch of test jars checked into the source. Is there ALv2 > provenance for all of them (including the sparkr tarball )? > Test jars are part of testing Magic downloading. They are ours. > > > On Thu, Oct 13, 2016 at 6:00 PM Hitesh Shah <hit...@apache.org> wrote: > >> md5/sha sigs look fine. pgp sig also looked good though see below. >> >> Comments: >> - no KEYS file so no way to verify the gpg signature ( unless one >> downloads an unverified key from a public server ) >> - bin tarball should untar into an apache-toree-incubating or >> apache-toree directory, source tarball untars into ./ - should be fixed to >> use a top-level dir IMO. >> - Something to check on - are the copyrights needed in the NOTICE file >> or the LICENSE file? I am not too sure if there are needed in the NOTICE >> file. >> - licenses/LICENSE-jline.txt seems to have some html but not the actual >> license content. Did not look at all the files so folks should re-check >> those. >> - Most projects tend to have one license file per license type and not >> a license file per dependency - with the copyrights called out in the main >> LICENSE file I believe. >> - source tarball seems to have too many licenses. Unless >> jline/scala,asm.ammonite, etc are bundled into the source tarball, they do >> not need to be called out in the LICENSE and/or NOTICE file. >> - bunch of markdown files without a license header >> - there are a bunch of test jars checked into the source. Is there ALv2 >> provenance for all of them (including the sparkr tarball )? >> >> Vote thread has a bahir related typo. >> >> thanks >> — Hitesh >> >> >>> On Oct 11, 2016, at 12:16 PM, Gino Bustelo <g...@bustelos.com> wrote: >>> >>> Please vote to approve the release of the following candidate as >>> Apache Toree version 0.1.0 >>> >>> >>> The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8 >>> < >> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8 >>> >>> >>> >> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8 >>> < >> https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee69e478555f7 >>> >>> >>> All distribution packages, including signatures, digests, etc. can be >> found at: >>> >>> *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/ >>> <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>* >>> >>> The vote is open for at least 72 hours and passes if a majority of at >> least >>> 3 +1 PMC votes are cast. >>> >>> [ ] +1 Release this package as Apache Toree 0.1.0 >>> [ ] -1 Do not release this package because ... >> >>
