[
https://issues.apache.org/jira/browse/TOREE-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048198#comment-16048198
]
ASF GitHub Bot commented on TOREE-380:
--------------------------------------
Github user chipsenkbeil commented on a diff in the pull request:
https://github.com/apache/incubator-toree/pull/104#discussion_r121751964
--- Diff:
kernel/src/test/scala/org/apache/toree/kernel/protocol/v5/stream/KernelInputStreamSpec.scala
---
@@ -65,6 +65,9 @@ class KernelInputStreamSpec
// set of data
doReturn(system.actorSelection(fakeInputOutputHandlerActor.path.toString))
.when(mockActorLoader).load(MessageType.Incoming.InputReply)
+ // Allow time for the actors to start. This avoids read() hanging
forever
+ // when running tests in gradle.
+ Thread.sleep(100)
--- End diff --
I _really_ dislike `sleep` calls. Is there any better way to do this? Is
there any flag or way to know when the actors have started and use a future,
callback, or something here rather than a thread sleep?
> Interpreters should be allowed to send results other than text/plain.
> ---------------------------------------------------------------------
>
> Key: TOREE-380
> URL: https://issues.apache.org/jira/browse/TOREE-380
> Project: TOREE
> Issue Type: Improvement
> Reporter: Ryan Blue
> Assignee: Ryan Blue
>
> Jupyter allows kernels to send results using different content types, but
> this isn't allowed by Toree for its interpreters. This prevents custom
> display logic. The basic problem is that {{ExecuteOutput}} is a {{String}}
> and not a {{Map[String, String]}} like {{CellMagicOutput}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
